public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/3] mtd: Fix partition handling code
Date: Wed, 31 Oct 2018 11:43:18 +0100	[thread overview]
Message-ID: <20181031114318.2cb4e4f3@xps13> (raw)
In-Reply-To: <20181031100736.3067-1-boris.brezillon@bootlin.com>

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Wed, 31 Oct 2018
11:07:33 +0100:

> Hello,
> 
> Stefan recently reported a bug when using ubi part on a spi-nand
> device and proposed this fix[1]. While his solution while working
> I proposed a different approach to kill the CMD_UBI dependency on
> CMD_MTDPARTS. This is what patches 1 and 2 are doing.
> 
> Patch 3 is just removing the duplicate Kconfig MTD_PARTITIONS entry.
> 
> Jagan, can you queue those patches to one of your branch and send a
> fixes PR, unless Tom prefers to take them directly.
> 
> Regards,
> 
> Boris
> 
> Boris Brezillon (3):
>   mtd: Use default mtdparts/mtids when not defined in the environment
>   cmd: ubi: Remove useless call to mtdparts_init()
>   mtd: Drop duplicate MTD_PARTITIONS Kconfig option

Strange, we already had a discussion about it. But indeed this patch is
needed.

> 
>  cmd/Kconfig             |  1 -
>  cmd/ubi.c               |  5 ----
>  drivers/mtd/Kconfig     |  6 ----
>  drivers/mtd/mtd_uboot.c | 62 +++++++++++++++++++++++++++++++++++++++--
>  4 files changed, 60 insertions(+), 14 deletions(-)
> 

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl

  parent reply	other threads:[~2018-10-31 10:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 10:07 [U-Boot] [PATCH 0/3] mtd: Fix partition handling code Boris Brezillon
2018-10-31 10:07 ` [U-Boot] [PATCH 1/3] mtd: Use default mtdparts/mtids when not defined in the environment Boris Brezillon
2018-10-31 10:07 ` [U-Boot] [PATCH 2/3] cmd: ubi: Remove useless call to mtdparts_init() Boris Brezillon
2018-10-31 10:07 ` [U-Boot] [PATCH 3/3] mtd: Drop duplicate MTD_PARTITIONS Kconfig option Boris Brezillon
2018-10-31 10:43 ` Miquel Raynal [this message]
2018-11-05  8:37 ` [U-Boot] [PATCH 0/3] mtd: Fix partition handling code Jagan Teki
2018-11-10  9:32   ` Jagan Teki
2018-11-10 11:23     ` Boris Brezillon
2018-11-10 11:27       ` Jagan Teki
2018-11-10 11:33         ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031114318.2cb4e4f3@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox