From mboxrd@z Thu Jan  1 00:00:00 1970
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
Date: Thu, 1 Nov 2018 14:11:19 +0900
Subject: [U-Boot] [PATCH v3 10/26] fs: fat: support write with non-zero
 offset
In-Reply-To: <f063613d-fe13-3cf1-3673-2a7573457c2e@gmx.de>
References: <20180911065922.19141-1-takahiro.akashi@linaro.org>
 <20180911065922.19141-11-takahiro.akashi@linaro.org>
 <7602021b-50a2-392a-7da3-b9c7e2d2d716@ti.com>
 <CAJiuCcdQFM0gD5iDqLYghAy4pdcCKrhvjsVWpaA6omSzncfd5A@mail.gmail.com>
 <f72cc571-4b34-6454-4c8a-4cf8617acbf6@suse.de>
 <f063613d-fe13-3cf1-3673-2a7573457c2e@gmx.de>
Message-ID: <20181101051118.GM11663@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
To: u-boot@lists.denx.de

On Wed, Oct 31, 2018 at 09:54:14PM +0100, Heinrich Schuchardt wrote:
> On 10/31/2018 01:22 PM, Alexander Graf wrote:
> > On 10/31/2018 11:00 AM, Clément Péron wrote:
> >> Hi,
> >>
> >> Trying to rebuild my SoCFPGA Cyclone V board and got this error :
> >>
> >> fs/built-in.o: In function `set_contents':
> >> /home/cperon/u-boot/fs/fat/fat_write.c:831: undefined reference to
> >> `__aeabi_ldivmod'
> >> make: *** [Makefile:1381: u-boot] Error 1
> >>
> >> seems to be introduced with this operation :
> >> assert(!(cur_pos % bytesperclust));
> > 
> > Could we maybe just use a bitmask for bytesperclust?
> > 
> > 
> > Alex
> 
> According to the FAT specification the cluster size is a power of two.
> So we can write

I found:
"Count of bytes per sector. This value may take on
 only the following values: 512, 1024, 2048 or 4096."

> assert(!(cur_pos & (bytesperclust -1)));

It seems reasonably good.

Thanks,
-Takahiro Akashi

> Cf. patch
> https://lists.denx.de/pipermail/u-boot/2018-October/346178.html
> fs: fat: validate sector and cluster size.
> 
> Best regards
> 
> Heinrich