From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] w1-eeprom: ds24xxx: fix data abort in ds24xxx_probe()
Date: Fri, 2 Nov 2018 16:29:45 -0400 [thread overview]
Message-ID: <20181102202945.GJ1032@bill-the-cat> (raw)
In-Reply-To: <1540225879-17841-1-git-send-email-martin.fuzzey@flowbird.group>
On Mon, Oct 22, 2018 at 06:31:07PM +0200, Martin Fuzzey wrote:
> Data abort was occurring when using "w1 bus" with a DS24B33 present.
>
> The abort occurred in the ds24xxx_probe() because the struct w1_device
> pointer was NULL. This is because that structure is allocated by
> the parent device uclass (by .per_child_platdata_auto_alloc_size)
> and thus the correct accessor is dev_get_parent_platdata() not
> dev_get_platdata()
>
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
> Reviewed-by: Eugen Hristev <eugen.hristev@microchip.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181102/7e1f582b/attachment.sig>
prev parent reply other threads:[~2018-11-02 20:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 16:31 [U-Boot] [PATCH] w1-eeprom: ds24xxx: fix data abort in ds24xxx_probe() Martin Fuzzey
2018-10-22 16:31 ` [U-Boot] [PATCH] w1: fix data abort if no one wire bus master present Martin Fuzzey
2018-10-23 7:05 ` Eugen.Hristev at microchip.com
2018-10-23 8:17 ` Martin Fuzzey
2018-10-23 8:30 ` Eugen.Hristev at microchip.com
2018-11-02 20:29 ` [U-Boot] " Tom Rini
2018-10-23 6:51 ` [U-Boot] [PATCH] w1-eeprom: ds24xxx: fix data abort in ds24xxx_probe() Eugen.Hristev at microchip.com
2018-11-02 20:29 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102202945.GJ1032@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox