From: Vasily Khoruzhick <anarsoul@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] sunxi-mmc: don't double clock for new mode unconditionally
Date: Fri, 9 Nov 2018 20:41:45 -0800 [thread overview]
Message-ID: <20181110044146.1855-3-anarsoul@gmail.com> (raw)
In-Reply-To: <20181110044146.1855-1-anarsoul@gmail.com>
Comment in Linux driver says that clock needs to be doubled only
if we use DDR modes, moreover divider has to be set accordingly.
U-boot driver doesn't declare support for any DDR modes and doesn't
set internal clock divider in CLKCR, so it doubles clock
unconditionally when new mode is used.
Some cards can't handle that and as result SPL fails to load u-boot.
Fixes: de9b1771c3b ("mmc: sunxi: Support new mode")
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/mmc/sunxi_mmc.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/mmc/sunxi_mmc.c b/drivers/mmc/sunxi_mmc.c
index b3526f5e3f..e50b2c3343 100644
--- a/drivers/mmc/sunxi_mmc.c
+++ b/drivers/mmc/sunxi_mmc.c
@@ -109,13 +109,6 @@ static int mmc_set_mod_clk(struct sunxi_mmc_priv *priv, unsigned int hz)
calibrate = true;
#endif
- /*
- * The MMC clock has an extra /2 post-divider when operating in the new
- * mode.
- */
- if (new_mode)
- hz = hz * 2;
-
if (hz <= 24000000) {
pll = CCM_MMC_CTRL_OSCM24;
pll_hz = 24000000;
--
2.19.1
next prev parent reply other threads:[~2018-11-10 4:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 4:41 [U-Boot] [PATCH v2 0/3] sunxi-mmc: enable new clock mode on A64 Vasily Khoruzhick
2018-11-10 4:41 ` [U-Boot] [PATCH v2 1/3] sunxi-mmc: introduce new MMC_SUNXI_HAS_MODE_SWITCH option Vasily Khoruzhick
2018-11-22 7:51 ` Jagan Teki
2018-11-10 4:41 ` Vasily Khoruzhick [this message]
2018-11-22 7:52 ` [U-Boot] [PATCH v2 2/3] sunxi-mmc: don't double clock for new mode unconditionally Jagan Teki
2018-11-10 4:41 ` [U-Boot] [PATCH v2 3/3] sunxi-mmc: use new mode on both controllers on A64 Vasily Khoruzhick
2018-11-22 7:53 ` Jagan Teki
2018-11-15 19:20 ` [U-Boot] [PATCH v2 0/3] sunxi-mmc: enable new clock mode " Vasily Khoruzhick
2018-11-21 20:30 ` Vasily Khoruzhick
2018-11-22 6:02 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181110044146.1855-3-anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox