From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mtd: Fix dependency of {MTDIDS, MTDPARTS}_DEFAULT
Date: Sat, 10 Nov 2018 12:22:09 +0100 [thread overview]
Message-ID: <20181110112209.28872-2-boris.brezillon@bootlin.com> (raw)
In-Reply-To: <20181110112209.28872-1-boris.brezillon@bootlin.com>
The gwventana platform was relying on CMD_UBI to select CMD_MTDPARTS,
which was then making {MTDIDS,MTDPARTS}_DEFAULT available.
Now that UBI no longer selects CMD_MTDPARTS, we end up with a build
failure because those defaults are not defined.
Fix that by making adjusting the depends on of these options: we now
depends on MTD_PARTITIONS, so that option selecting MTD_PARTITIONS
(which is the case of CMD_UBI) also gets those default values.
We also get rid of the depends on CMD_MTD, since CMD_MTD also selects
MTD_PARTITIONS.
Reported-by: Jagan Teki <jagan@amarulasolutions.com>
Fixes: c7da70c1eb94 ("cmd: ubi: Remove useless call to mtdparts_init()")
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
cmd/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index b47e7fe80dbb..ad14c9ce7124 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1728,14 +1728,14 @@ config CMD_MTDPARTS
config MTDIDS_DEFAULT
string "Default MTD IDs"
- depends on CMD_MTD || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
+ depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
help
Defines a default MTD IDs list for use with MTD partitions in the
Linux MTD command line partitions format.
config MTDPARTS_DEFAULT
string "Default MTD partition scheme"
- depends on CMD_MTD || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
+ depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
help
Defines a default MTD partitioning scheme in the Linux MTD command
line partitions format
--
2.17.1
next prev parent reply other threads:[~2018-11-10 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-10 11:22 [U-Boot] [PATCH 1/2] dfu: nand: Add missing dependency on CMD_MTDPARTS Boris Brezillon
2018-11-10 11:22 ` Boris Brezillon [this message]
2018-11-12 4:43 ` Jagan Teki
2018-11-12 6:45 ` Boris Brezillon
2018-11-12 7:11 ` Jagan Teki
2018-11-12 8:36 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181110112209.28872-2-boris.brezillon@bootlin.com \
--to=boris.brezillon@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox