public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier
@ 2018-11-10 15:37 Andy Shevchenko
  2018-11-10 15:37 ` [U-Boot] [PATCH v1 2/2] x86: acpi: Fix indentation in Intel Tangier ASL code Andy Shevchenko
  2018-11-13  8:41 ` [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier Bin Meng
  0 siblings, 2 replies; 6+ messages in thread
From: Andy Shevchenko @ 2018-11-10 15:37 UTC (permalink / raw)
  To: u-boot

Intel Tangier SoC has RTC inside. So, enable it in ACPI.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 arch/x86/include/asm/arch-tangier/acpi/platform.asl | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/x86/include/asm/arch-tangier/acpi/platform.asl b/arch/x86/include/asm/arch-tangier/acpi/platform.asl
index 7abea4bb96..353b879918 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/platform.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/platform.asl
@@ -21,6 +21,19 @@ Method(_WAK, 1)
     Return (Package() {0, 0})
 }
 
+Scope (_SB)
+{
+    /* Real Time Clock */
+    Device (RTC0)
+    {
+        Name (_HID, EisaId ("PNP0B00"))
+        Name (_CRS, ResourceTemplate()
+        {
+            IO(Decode16, 0x70, 0x70, 0x01, 0x08)
+        })
+    }
+}
+
 /* ACPI global NVS */
 #include "global_nvs.asl"
 
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v1 2/2] x86: acpi: Fix indentation in Intel Tangier ASL code
  2018-11-10 15:37 [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier Andy Shevchenko
@ 2018-11-10 15:37 ` Andy Shevchenko
  2018-11-13  8:41   ` Bin Meng
  2018-11-13  8:41 ` [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier Bin Meng
  1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-11-10 15:37 UTC (permalink / raw)
  To: u-boot

Make the indentation aligned with what used elsewhere in U-Boot.

No functional change intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 .../include/asm/arch-tangier/acpi/southcluster.asl   | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
index 48193ba957..e166e510cb 100644
--- a/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
+++ b/arch/x86/include/asm/arch-tangier/acpi/southcluster.asl
@@ -295,16 +295,16 @@ Device (PCI0)
 
             Method (_CRS, 0, Serialized)
             {
-                Name (RBUF, ResourceTemplate ()
+                Name (RBUF, ResourceTemplate()
                 {
-                    UartSerialBus (0x0001C200, DataBitsEight, StopBitsOne,
+                    UartSerialBus(0x0001C200, DataBitsEight, StopBitsOne,
                         0xFC, LittleEndian, ParityTypeNone, FlowControlHardware,
                         0x20, 0x20, "\\_SB.PCI0.HSU0", 0, ResourceConsumer, , )
-                    GpioInt (Level, ActiveHigh, Exclusive, PullNone, 0,
+                    GpioInt(Level, ActiveHigh, Exclusive, PullNone, 0,
                         "\\_SB.PCI0.GPIO", 0, ResourceConsumer, , ) { 185 }
-                    GpioIo (Exclusive, PullDefault, 0, 0, IoRestrictionOutputOnly,
+                    GpioIo(Exclusive, PullDefault, 0, 0, IoRestrictionOutputOnly,
                         "\\_SB.PCI0.GPIO", 0, ResourceConsumer, , ) { 184 }
-                    GpioIo (Exclusive, PullDefault, 0, 0, IoRestrictionOutputOnly,
+                    GpioIo(Exclusive, PullDefault, 0, 0, IoRestrictionOutputOnly,
                         "\\_SB.PCI0.GPIO", 0, ResourceConsumer, , ) { 71 }
                 })
                 Return (RBUF)
@@ -328,7 +328,7 @@ Device (FLIS)
     Name (_DDN, "Intel Merrifield Family-Level Interface Shim")
     Name (RBUF, ResourceTemplate()
     {
-        Memory32Fixed(ReadWrite, 0xFF0C0000, 0x00008000, )
+        Memory32Fixed(ReadWrite, 0xFF0C0000, 0x00008000)
         PinGroup("spi5", ResourceProducer, ) { 90, 91, 92, 93, 94, 95, 96 }
         PinGroup("uart0", ResourceProducer, ) { 115, 116, 117, 118 }
         PinGroup("uart1", ResourceProducer, ) { 119, 120, 121, 122 }
-- 
2.19.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier
  2018-11-10 15:37 [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier Andy Shevchenko
  2018-11-10 15:37 ` [U-Boot] [PATCH v1 2/2] x86: acpi: Fix indentation in Intel Tangier ASL code Andy Shevchenko
@ 2018-11-13  8:41 ` Bin Meng
  2018-11-18 12:43   ` Bin Meng
  1 sibling, 1 reply; 6+ messages in thread
From: Bin Meng @ 2018-11-13  8:41 UTC (permalink / raw)
  To: u-boot

On Sat, Nov 10, 2018 at 11:37 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Intel Tangier SoC has RTC inside. So, enable it in ACPI.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  arch/x86/include/asm/arch-tangier/acpi/platform.asl | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v1 2/2] x86: acpi: Fix indentation in Intel Tangier ASL code
  2018-11-10 15:37 ` [U-Boot] [PATCH v1 2/2] x86: acpi: Fix indentation in Intel Tangier ASL code Andy Shevchenko
@ 2018-11-13  8:41   ` Bin Meng
  2018-11-18 12:43     ` Bin Meng
  0 siblings, 1 reply; 6+ messages in thread
From: Bin Meng @ 2018-11-13  8:41 UTC (permalink / raw)
  To: u-boot

On Sat, Nov 10, 2018 at 11:37 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Make the indentation aligned with what used elsewhere in U-Boot.
>
> No functional change intended.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  .../include/asm/arch-tangier/acpi/southcluster.asl   | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier
  2018-11-13  8:41 ` [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier Bin Meng
@ 2018-11-18 12:43   ` Bin Meng
  0 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2018-11-18 12:43 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 13, 2018 at 4:41 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Sat, Nov 10, 2018 at 11:37 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Intel Tangier SoC has RTC inside. So, enable it in ACPI.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/x86/include/asm/arch-tangier/acpi/platform.asl | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [U-Boot] [PATCH v1 2/2] x86: acpi: Fix indentation in Intel Tangier ASL code
  2018-11-13  8:41   ` Bin Meng
@ 2018-11-18 12:43     ` Bin Meng
  0 siblings, 0 replies; 6+ messages in thread
From: Bin Meng @ 2018-11-18 12:43 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 13, 2018 at 4:41 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Sat, Nov 10, 2018 at 11:37 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Make the indentation aligned with what used elsewhere in U-Boot.
> >
> > No functional change intended.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  .../include/asm/arch-tangier/acpi/southcluster.asl   | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-11-18 12:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-10 15:37 [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier Andy Shevchenko
2018-11-10 15:37 ` [U-Boot] [PATCH v1 2/2] x86: acpi: Fix indentation in Intel Tangier ASL code Andy Shevchenko
2018-11-13  8:41   ` Bin Meng
2018-11-18 12:43     ` Bin Meng
2018-11-13  8:41 ` [U-Boot] [PATCH v1 1/2] x86: acpi: Enable RTC for Intel Tangier Bin Meng
2018-11-18 12:43   ` Bin Meng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox