From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Mon, 12 Nov 2018 12:00:45 +0100 Subject: [U-Boot] [PATCH v2 3/5] mtd: Make {MTDIDS, MTDPARTS}_DEFAULT visible when MTD_PARTITIONS is selected In-Reply-To: <20181112082809.7035-3-boris.brezillon@bootlin.com> References: <20181112082809.7035-1-boris.brezillon@bootlin.com> <20181112082809.7035-3-boris.brezillon@bootlin.com> Message-ID: <20181112120045.3e00c2e4@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, 12 Nov 2018 09:28:07 +0100 Boris Brezillon wrote: > gwventana configs are relying on CMD_UBI to select CMD_MTDPARTS, > which is then making {MTDIDS,MTDPARTS}_DEFAULT options available. > > We are about to remove the 'select CMD_MTDPARTS' statement in the > CMD_UBI entry, but if we do that without first making sure > {MTDIDS,MTDPARTS}_DEFAULT are visible, we end up with a build > failure when building gwventana configs. > > Address that by adding a depends on MTD_PARTITIONS to > {MTDIDS,MTDPARTS}_DEFAULT which does the trick since CMD_UBI selects > MTD_UBI which in turn selects MTD_PARTITIONS. > > We also get rid of the depends on CMD_MTD, since CMD_MTD also selects > MTD_PARTITIONS. > > Reported-by: Jagan Teki > Signed-off-by: Boris Brezillon > --- > Changes in v2: > - Moved ealier in the series to avoid introducing a build failure > --- > cmd/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index d66f710ad0f8..9310a8bdb2b7 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1728,14 +1728,14 @@ config CMD_MTDPARTS > > config MTDIDS_DEFAULT > string "Default MTD IDs" > - depends on CMD_MTD || CMD_MTDPARTS || CMD_NAND || CMD_FLASH > + depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || > CMD_FLASH help > Defines a default MTD IDs list for use with MTD partitions > in the Linux MTD command line partitions format. > > config MTDPARTS_DEFAULT > string "Default MTD partition scheme" > - depends on CMD_MTD || CMD_MTDPARTS || CMD_NAND || CMD_FLASH > + depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || > CMD_FLASH help > Defines a default MTD partitioning scheme in the Linux MTD > command line partitions format Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: