public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/5] mtd: Drop duplicate MTD_PARTITIONS Kconfig option
Date: Mon, 12 Nov 2018 12:01:33 +0100	[thread overview]
Message-ID: <20181112120133.6213b374@jawa> (raw)
In-Reply-To: <20181112082809.7035-5-boris.brezillon@bootlin.com>

On Mon, 12 Nov 2018 09:28:09 +0100
Boris Brezillon <boris.brezillon@bootlin.com> wrote:

> Commit 9c5b00973bce ("Convert CONFIG_MTD_PARTITIONS et al to Kconfig")
> introduced a publicly visible Kconfig entry for the
> CONFIG_MTD_PARTITIONS option, while the rework on MTD partitioning
> was in progress, and we somehow did not notice that the same Kconfig
> entry was added by commit 4048a5c519a8 ("mtd: declare MTD_PARTITIONS
> symbol in Kconfig"), but this time as an invisible entry (this can
> only be selected by other options).
> 
> Keep the non-visible version of this symbol, since MTD_PARTITIONS is
> not something the user should be able to enable/disable directly.
> 
> Fixes: 4048a5c519a8 ("mtd: declare MTD_PARTITIONS symbol in Kconfig")
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> ---
> Changes in v2:
> - Moved after the patches reworking the Kconfig deps
> ---
>  drivers/mtd/Kconfig | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> index 11cf12bb5599..0050fb2b9bf1 100644
> --- a/drivers/mtd/Kconfig
> +++ b/drivers/mtd/Kconfig
> @@ -22,12 +22,6 @@ config MTD_DEVICE
>  	  Adds the MTD device infrastructure from the Linux kernel.
>  	  Needed for mtdparts command support.
>  
> -config MTD_PARTITIONS
> -	bool "Add MTD Partioning infrastructure"
> -	help
> -	  Adds the MTD partitioning infrastructure from the Linux
> -	  kernel. Needed for UBI support.
> -
>  config FLASH_CFI_DRIVER
>  	bool "Enable CFI Flash driver"
>  	help


Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181112/f6238be3/attachment.sig>

  reply	other threads:[~2018-11-12 11:01 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-12  8:28 [U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment Boris Brezillon
2018-11-12  8:28 ` [U-Boot] [PATCH v2 2/5] dfu: nand: Add missing dependency on CMD_MTDPARTS Boris Brezillon
2018-11-12 11:00   ` Lukasz Majewski
2018-11-12  8:28 ` [U-Boot] [PATCH v2 3/5] mtd: Make {MTDIDS, MTDPARTS}_DEFAULT visible when MTD_PARTITIONS is selected Boris Brezillon
2018-11-12 11:00   ` Lukasz Majewski
2018-11-12  8:28 ` [U-Boot] [PATCH v2 4/5] cmd: ubi: Remove useless call to mtdparts_init() Boris Brezillon
2018-11-12 11:01   ` Lukasz Majewski
2018-11-12  8:28 ` [U-Boot] [PATCH v2 5/5] mtd: Drop duplicate MTD_PARTITIONS Kconfig option Boris Brezillon
2018-11-12 11:01   ` Lukasz Majewski [this message]
2018-11-12  9:24 ` [U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment Miquel Raynal
2018-11-12 10:09   ` Jagan Teki
2018-11-12 11:00     ` Miquel Raynal
2018-11-12 10:25 ` Jagan Teki
2018-11-12 15:51   ` Boris Brezillon
2018-11-12 10:59 ` Lukasz Majewski
2018-11-13 11:01 ` Marek Vasut
2018-11-13 11:34   ` Boris Brezillon
2018-11-13 12:14     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181112120133.6213b374@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox