From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment
Date: Mon, 12 Nov 2018 16:51:51 +0100 [thread overview]
Message-ID: <20181112165151.7033da7a@bbrezillon> (raw)
In-Reply-To: <CAMty3ZAmn7c-YWwGS_JEVb4nxT6Tg-NTYgCR33ZRz5S8u6PxwA@mail.gmail.com>
On Mon, 12 Nov 2018 15:55:18 +0530
Jagan Teki <jagan@amarulasolutions.com> wrote:
> On Mon, Nov 12, 2018 at 1:58 PM Boris Brezillon
> <boris.brezillon@bootlin.com> wrote:
> >
> > U-boot provides a mean to define default values for mtdids and mtdparts
> > when they're not defined in the environment. Patch mtd_probe_devices()
> > to use those default values when env_get("mtdparts") or
> > env_get("mtdids") return NULL.
> >
> > This implementation is based on the logic found in cmd/mtdparts.c.
> >
> > Fixes: 5db66b3aee6f ("cmd: mtd: add 'mtd' command")
> > Reported-by: Stefan Roese <sr@denx.de>
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > Tested-by: Stefan Roese <sr@denx.de>
> > ---
> > Changes in v2:
> > - none
>
> Trigger travis-ci [1], will send v2 PR once all built fine.
>
> [1] https://travis-ci.org/openedev/u-boot-amarula/builds
Looks like mine is all green [1] ;-). And yes, now I have travis-ci
set up to track my u-boot repo, so hopefully I won't end up submitting
patches that regress the tests described in .travis.yaml in the future.
Still, I'd like to insist on that this test result shouldn't replace
human review, which I think is still valuable to spot subtle issues.
Also, I'd like to point that some of the failures caused by the
spi-nand patchset are actually coming from the weird way MTD related
config options are selected/defined in u-boot. This should probably be
simplified somehow, but that's a different story.
[1]https://travis-ci.org/bbrezillon/u-boot
next prev parent reply other threads:[~2018-11-12 15:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 8:28 [U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment Boris Brezillon
2018-11-12 8:28 ` [U-Boot] [PATCH v2 2/5] dfu: nand: Add missing dependency on CMD_MTDPARTS Boris Brezillon
2018-11-12 11:00 ` Lukasz Majewski
2018-11-12 8:28 ` [U-Boot] [PATCH v2 3/5] mtd: Make {MTDIDS, MTDPARTS}_DEFAULT visible when MTD_PARTITIONS is selected Boris Brezillon
2018-11-12 11:00 ` Lukasz Majewski
2018-11-12 8:28 ` [U-Boot] [PATCH v2 4/5] cmd: ubi: Remove useless call to mtdparts_init() Boris Brezillon
2018-11-12 11:01 ` Lukasz Majewski
2018-11-12 8:28 ` [U-Boot] [PATCH v2 5/5] mtd: Drop duplicate MTD_PARTITIONS Kconfig option Boris Brezillon
2018-11-12 11:01 ` Lukasz Majewski
2018-11-12 9:24 ` [U-Boot] [PATCH v2 1/5] mtd: Use default mtdparts/mtids when not defined in the environment Miquel Raynal
2018-11-12 10:09 ` Jagan Teki
2018-11-12 11:00 ` Miquel Raynal
2018-11-12 10:25 ` Jagan Teki
2018-11-12 15:51 ` Boris Brezillon [this message]
2018-11-12 10:59 ` Lukasz Majewski
2018-11-13 11:01 ` Marek Vasut
2018-11-13 11:34 ` Boris Brezillon
2018-11-13 12:14 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181112165151.7033da7a@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox