public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: Use get_mtdids() instead of env_get("mtdids") in mtd_search_alternate_name()
Date: Sun, 18 Nov 2018 20:29:05 +0100	[thread overview]
Message-ID: <20181118202905.779cb2b9@bbrezillon> (raw)
In-Reply-To: <20181117115952.723fa682@xps13>

On Sat, 17 Nov 2018 11:59:52 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Hi Boris,
> 
> Boris Brezillon <boris.brezillon@bootlin.com> wrote on Fri, 16 Nov 2018
> 23:15:42 +0100:
> 
> > The environment is not guaranteed to contain a valid mtdids variable
> > when called from mtd_search_alternate_name(). Call get_mtdids() instead
> > of env_get("mtdids").

Forgot to move board_mtdparts_default(). Please don't apply this patch,
I'll send a v2.

> > 
> > Fixes: ff4afa8a981e ("mtd: uboot: search for an equivalent MTD name with the mtdids")
> > Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
> > ---  
> 
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> 
> Thanks,
> Miquèl

      reply	other threads:[~2018-11-18 19:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-16 22:15 [U-Boot] [PATCH] mtd: Use get_mtdids() instead of env_get("mtdids") in mtd_search_alternate_name() Boris Brezillon
2018-11-17 10:59 ` Miquel Raynal
2018-11-18 19:29   ` Boris Brezillon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181118202905.779cb2b9@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox