From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Sun, 18 Nov 2018 21:13:47 +0100
Subject: [U-Boot] [PATCH 2/2] mtd: fix Coverity integer handling issue
In-Reply-To: <20181118201147.11257-2-miquel.raynal@bootlin.com>
References: <20181118201147.11257-1-miquel.raynal@bootlin.com>
 <20181118201147.11257-2-miquel.raynal@bootlin.com>
Message-ID: <20181118211347.47efa9b0@xps13>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hello,

Miquel Raynal <miquel.raynal@bootlin.com> wrote on Sun, 18 Nov 2018
21:11:47 +0100:

> A Coverity robot reported an integer handling issue
> (OVERFLOW_BEFORE_WIDEN) in the potentially overflowing expression:
>=20
>     (mtd_div_by_ws(mtd->size, mtd) - mtd_div_by_ws(offs, mtd)) *
>     mtd_oobavail(mtd, ops)
>=20
> While such overflow will certainly never happen due to the numbers
> handled, it is cleaner to fix this operation anyway.
>=20
> The problem is that all the maths include 32-bit quantities, while the
> result is stored in an explicit 64-bit value.
>=20
> As maxooblen will just be compared with a size_t, let's change the
> type of the variable to a size_t. This will not fix anything but will
> clarify a bit the situation. Then, do an explicit cast to fix Coverity
> warning.
>=20
> Addresses-Coverity-ID: 184180 ("Integer handling issues")
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---

I forgot to add the link to the corresponding Travis-CI job:
https://travis-ci.org/miquelraynal/u-boot/builds/456679982

Thanks,
Miqu=C3=A8l