From: Boris Brezillon <boris.brezillon@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/9] mtd: Delete partitions attached to the device when a device is deleted
Date: Mon, 19 Nov 2018 12:51:15 +0100 [thread overview]
Message-ID: <20181119115121.7699-3-boris.brezillon@bootlin.com> (raw)
In-Reply-To: <20181119115121.7699-1-boris.brezillon@bootlin.com>
If we don't do that, partitions might still be exposed while the
underlying device is gone.
Fixes: 2a74930da57f ("mtd: mtdpart: implement proper partition handling")
Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
---
Changes in v2:
- Fix build failures when CONFIG_MTD_PARTITIONS is not enabled
---
drivers/mtd/mtdcore.c | 1 +
include/linux/mtd/mtd.h | 15 +++++++++++++++
2 files changed, 16 insertions(+)
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
index 7a15ded8c883..46657fe7c949 100644
--- a/drivers/mtd/mtdcore.c
+++ b/drivers/mtd/mtdcore.c
@@ -528,6 +528,7 @@ int del_mtd_device(struct mtd_info *mtd)
struct mtd_notifier *not;
#endif
+ del_mtd_partitions(mtd);
mutex_lock(&mtd_table_mutex);
if (idr_find(&mtd_idr, mtd->index) != mtd) {
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index d20ebd820289..4d0096d9f1d8 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -562,8 +562,23 @@ unsigned mtd_mmap_capabilities(struct mtd_info *mtd);
/* drivers/mtd/mtdcore.h */
int add_mtd_device(struct mtd_info *mtd);
int del_mtd_device(struct mtd_info *mtd);
+
+#ifdef CONFIG_MTD_PARTITIONS
int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *, int);
int del_mtd_partitions(struct mtd_info *);
+#else
+static inline int add_mtd_partitions(struct mtd_info *mtd,
+ const struct mtd_partition *parts,
+ int nparts)
+{
+ return 0;
+}
+
+static inline int del_mtd_partitions(struct mtd_info *mtd)
+{
+ return 0;
+}
+#endif
struct mtd_info *__mtd_next_device(int i);
#define mtd_for_each_device(mtd) \
--
2.17.1
next prev parent reply other threads:[~2018-11-19 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 11:51 [U-Boot] [PATCH 1/9] mtd: Add a function to report when the MTD dev list has been updated Boris Brezillon
2018-11-19 11:51 ` [U-Boot] [PATCH 2/9] mtd: Parse mtdparts/mtdids again when the MTD " Boris Brezillon
2018-11-19 11:51 ` Boris Brezillon [this message]
2018-11-19 11:51 ` [U-Boot] [PATCH 4/9] mtd: sf: Make sure we don't register the same device twice Boris Brezillon
2018-11-19 11:51 ` [U-Boot] [PATCH 5/9] mtd: Use get_mtdids() instead of env_get("mtdids") in mtd_search_alternate_name() Boris Brezillon
2018-11-19 11:51 ` [U-Boot] [PATCH 6/9] mtd: Be more strict on the "mtdparts=" prefix check Boris Brezillon
2018-11-19 11:51 ` [U-Boot] [PATCH 7/9] mtd: Make sure the name passed in mtdparts fits in mtd_name[] Boris Brezillon
2018-11-19 11:51 ` [U-Boot] [PATCH 8/9] mtd: Make sure we don't parse MTD partitions belonging to another dev Boris Brezillon
2018-11-19 11:51 ` [U-Boot] [PATCH 9/9] mtd: Don't stop MTD partition creation when it fails on one device Boris Brezillon
2018-11-19 12:40 ` [U-Boot] [PATCH 1/9] mtd: Add a function to report when the MTD dev list has been updated Boris Brezillon
2018-11-19 13:30 ` Heiko Schocher
2018-11-19 13:44 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119115121.7699-3-boris.brezillon@bootlin.com \
--to=boris.brezillon@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox