public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] board: da8xxevm: Fix Environmental CRC error
@ 2018-11-20 14:43 Adam Ford
  2018-11-27 18:48 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Adam Ford @ 2018-11-20 14:43 UTC (permalink / raw)
  To: u-boot

When the spi_flash_probe_bus_cs() was previously called, it was
called using 0's for two values where CONFIG_ENV_SPI_MAX_HZ and
CONFIG_ENV_SPI_MODE are now used.  When changed this
caused the environment to fail the CRC check and the default
was used.  This patch defines both of these values back 0.

Fixes: 25a17652c9c2 ("fix: env: Fix the SPI flash device setup
for DM mode")

Signed-off-by: Adam Ford <aford173@gmail.com>

diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
index ba878eb13b..14a3046f19 100644
--- a/include/configs/da850evm.h
+++ b/include/configs/da850evm.h
@@ -124,8 +124,9 @@
 #ifdef CONFIG_SPL_BUILD
 #define CONFIG_SYS_SPI_BASE		DAVINCI_SPI1_BASE
 #define CONFIG_SF_DEFAULT_SPEED		30000000
-#define CONFIG_ENV_SPI_MAX_HZ	CONFIG_SF_DEFAULT_SPEED
 #endif
+#define CONFIG_ENV_SPI_MAX_HZ	0
+#define CONFIG_ENV_SPI_MODE	0
 
 #ifdef CONFIG_USE_SPIFLASH
 #define CONFIG_SYS_SPI_U_BOOT_OFFS	0x8000
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] board: da8xxevm: Fix Environmental CRC error
  2018-11-20 14:43 [U-Boot] [PATCH] board: da8xxevm: Fix Environmental CRC error Adam Ford
@ 2018-11-27 18:48 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-11-27 18:48 UTC (permalink / raw)
  To: u-boot

On Tue, Nov 20, 2018 at 08:43:13AM -0600, Adam Ford wrote:

> When the spi_flash_probe_bus_cs() was previously called, it was
> called using 0's for two values where CONFIG_ENV_SPI_MAX_HZ and
> CONFIG_ENV_SPI_MODE are now used.  When changed this
> caused the environment to fail the CRC check and the default
> was used.  This patch defines both of these values back 0.
> 
> Fixes: 25a17652c9c2 ("fix: env: Fix the SPI flash device setup
> for DM mode")
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> 
> diff --git a/include/configs/da850evm.h b/include/configs/da850evm.h
> index ba878eb13b..14a3046f19 100644

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181127/b2ba5c99/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-27 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-20 14:43 [U-Boot] [PATCH] board: da8xxevm: Fix Environmental CRC error Adam Ford
2018-11-27 18:48 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox