From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/1] fs: fat: validate sector and cluster size
Date: Tue, 20 Nov 2018 21:17:57 -0500 [thread overview]
Message-ID: <20181121021757.GP11247@bill-the-cat> (raw)
In-Reply-To: <ec3c37ec-24ef-5817-0bd1-e5ec2a47d4e8@gmx.de>
On Tue, Nov 20, 2018 at 11:08:54PM +0100, Heinrich Schuchardt wrote:
> On 11/20/18 9:33 PM, Tom Rini wrote:
> > On Tue, Nov 20, 2018 at 09:29:34PM +0100, Heinrich Schuchardt wrote:
> >
> >> On 11/20/18 3:56 PM, Tom Rini wrote:
> >>> On Wed, Oct 31, 2018 at 09:46:36PM +0100, Heinrich Schuchardt wrote:
> >>>
> >>>> In the rest of the FAT driver we want to be able to rely on the fact that
> >>>> the cluster size is a power of two. So let's check that both the sector
> >>>> size and the number of sectors per cluster are valid.
> >>>>
> >>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >>>
> >>> This breaks a number of tests under test/py/tests/test_fs/test_basic.py
> >>> as seen under 'make tests'.
> >>>
> >>
> >> Hello Tom,
> >>
> >> I am not able to reproduce your observation based on commit
> >> d73d81fd85e4a030ade42c4b2d13466d45090aa3 (master HEAD). See test output
> >> below.
> > [snip]
> >> test/py/tests/test_fs/test_basic.py
> >> sssssssssssssssssssssssssssssssssssssss
> >
> > OK, my fault for being imprecise. These tests here are the ones that
> > fail and you have them being skipped.
> > r
>
>
> make tests is building sandbox. Why are the tests skipped? I did not set
> them to skipped explicitly.
>
> The tests make reference to a file system. Where is it built?
I suspect that since it needs sudo to run, you don't have that allowed
and thus it goes with "skip" not running and pass/failing.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181120/c997aaa8/attachment.sig>
prev parent reply other threads:[~2018-11-21 2:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 20:46 [U-Boot] [PATCH 1/1] fs: fat: validate sector and cluster size Heinrich Schuchardt
2018-11-20 14:56 ` [U-Boot] [U-Boot, " Tom Rini
2018-11-20 20:29 ` Heinrich Schuchardt
2018-11-20 20:33 ` Tom Rini
2018-11-20 22:08 ` Heinrich Schuchardt
2018-11-21 2:17 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121021757.GP11247@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox