public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dts: am335x-pdu001: Fix polarity of card detection input
Date: Thu, 29 Nov 2018 15:27:39 -0500	[thread overview]
Message-ID: <20181129202739.GS5048@bill-the-cat> (raw)
In-Reply-To: <ad4e3152-dc23-4f71-e0c0-3756109af34a@ltec.ch>

On Thu, Nov 29, 2018 at 05:07:47PM +0100, Felix Brack wrote:
> On 29.11.2018 16:52, Tom Rini wrote:
> > On Thu, Nov 29, 2018 at 04:33:36PM +0100, Felix Brack wrote:
> >> On 29.11.2018 16:25, Tom Rini wrote:
> >>> On Thu, Nov 29, 2018 at 01:45:06PM +0100, Felix Brack wrote:
> >>>
> >>>> When a micro SD card is inserted in the PDU001 card cage, the card
> >>>> detection switch is opened and the corresponding GPIO input is driven
> >>>> by a pull-up. Hence change the active level of the card detection
> >>>> input from low to high.
> >>>>
> >>>> Signed-off-by: Felix Brack <fb@ltec.ch>
> >>>> ---
> >>>>
> >>>>  arch/arm/dts/am335x-pdu001.dts | 2 +-
> >>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/arch/arm/dts/am335x-pdu001.dts b/arch/arm/dts/am335x-pdu001.dts
> >>>> index 121e2c6207..3a5e952663 100644
> >>>> --- a/arch/arm/dts/am335x-pdu001.dts
> >>>> +++ b/arch/arm/dts/am335x-pdu001.dts
> >>>> @@ -576,7 +576,7 @@
> >>>>  	bus-width = <4>;
> >>>>  	pinctrl-names = "default";
> >>>>  	pinctrl-0 = <&mmc2_pins>;
> >>>> -	cd-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>;
> >>>> +	cd-gpios = <&gpio2 2 GPIO_ACTIVE_HIGH>;
> >>>>  };
> >>>>  
> >>>>  &sham {
> >>>
> >>> Is this in upstream Linux as well?  If so what tag/hash?  Thanks!
> >>>
> >> Not yet. I will send the Linux patch within a few days.
> >> The fix appears for U-Boot first as it is required for the upcoming
> >> patch that enables CONFIG_BLK and CONFIG_DM_MMC for this board.
> > 
> > Please reply to the thread with a ML link there so we can track and make
> > sure it doesn't get out of sync, thanks!
> > I'm not sure if I got that correctly. What is an 'ML link'?
> Was there something wrong with my last post or would you like me to post
> a message in this thread once the patch is in upstream Linux?

The general preference is that when we touch the dts files that aren't
U-Boot centric the commit message references the Linux githash/tag it's
taken from, for easier future re-syncs.  Since you're in progress on
fixing this in Linux too, you can just reply here so it's at least
tracked on the ML and archives that the change _is_ going upstream so we
aren't likely to overwrite it by accident later (and since you'd be the
one pushing a future re-sync, you'd also notice, so it's really not
likely to happen).  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181129/cf106c3f/attachment.sig>

  reply	other threads:[~2018-11-29 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 12:45 [U-Boot] [PATCH] dts: am335x-pdu001: Fix polarity of card detection input Felix Brack
2018-11-29 15:25 ` Tom Rini
2018-11-29 15:33   ` Felix Brack
2018-11-29 15:52     ` Tom Rini
2018-11-29 16:07       ` Felix Brack
2018-11-29 20:27         ` Tom Rini [this message]
2019-01-17 11:20           ` Felix Brack
2019-01-17 22:43             ` Tom Rini
2018-12-07 20:33 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129202739.GS5048@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox