public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: add clear screen 'cls' command
Date: Sat, 1 Dec 2018 10:46:46 +0100	[thread overview]
Message-ID: <20181201104646.53c1e8e4@crub> (raw)
In-Reply-To: <16561bdd84974912b21a710cac986154@SFHDAG6NODE3.st.com>

Hi Patrick,

On Mon, 19 Nov 2018 18:09:12 +0000
Patrick DELAUNAY patrick.delaunay at st.com wrote:
...
> > +config CMD_CLS
> > +	bool "Enable clear screen command 'cls'"
> > +	depends on CFB_CONSOLE || DM_VIDEO || LCD || VIDEO  
> 
> Just a minor remark, you can also add :
> 
> 	default y  if !DM_VIDEO

There are also a few boards with DM_VIDEO and LCD both enabled:

$ git grep CONFIG_LCD `git grep DM_VIDEO=y configs/ | awk -F : '{print $1}'`
configs/peach-pi_defconfig:CONFIG_LCD=y
configs/peach-pit_defconfig:CONFIG_LCD=y
configs/snow_defconfig:CONFIG_LCD=y
configs/spring_defconfig:CONFIG_LCD=y

so using y if !DM_VIDEO would disable the command for them.

> To avoid the defconfig modifications in the patch.
> (lcd.o if compiled ifndef CONFIG_DM_VIDEO) / command previously always define in this case)
> But you prefer perhaps to have clear CONFIG_CMD configuration in each defconfig.

I'd like to reduce the defconfig size, so v2 patch uses
"default y if LCD" to auto-select the command (compatibility for
existing CONFIG_LCD users). For other configurations the command
should be enabled in defconfig by users, when needed.

...
> But Ok for the rest. 
> Tested on my board (stm32mp157_ev1 with DM_VIDEO activated)
> 
> Regards, Patrick.
> 
> Tested-by: Patrick.Delaunay <patrick.delaunay@free.fr>

Thanks for testing it!

--
Anatolij

      reply	other threads:[~2018-12-01  9:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-17 14:30 [U-Boot] [PATCH] cmd: add clear screen 'cls' command Anatolij Gustschin
2018-11-19 18:09 ` Patrick DELAUNAY
2018-12-01  9:46   ` Anatolij Gustschin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181201104646.53c1e8e4@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox