From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Sat, 1 Dec 2018 10:46:46 +0100
Subject: [U-Boot] [PATCH] cmd: add clear screen 'cls' command
In-Reply-To: <16561bdd84974912b21a710cac986154@SFHDAG6NODE3.st.com>
References: <20181117143021.28188-1-agust@denx.de>
 <16561bdd84974912b21a710cac986154@SFHDAG6NODE3.st.com>
Message-ID: <20181201104646.53c1e8e4@crub>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Patrick,

On Mon, 19 Nov 2018 18:09:12 +0000
Patrick DELAUNAY patrick.delaunay at st.com wrote:
...
> > +config CMD_CLS
> > +	bool "Enable clear screen command 'cls'"
> > +	depends on CFB_CONSOLE || DM_VIDEO || LCD || VIDEO  
> 
> Just a minor remark, you can also add :
> 
> 	default y  if !DM_VIDEO

There are also a few boards with DM_VIDEO and LCD both enabled:

$ git grep CONFIG_LCD `git grep DM_VIDEO=y configs/ | awk -F : '{print $1}'`
configs/peach-pi_defconfig:CONFIG_LCD=y
configs/peach-pit_defconfig:CONFIG_LCD=y
configs/snow_defconfig:CONFIG_LCD=y
configs/spring_defconfig:CONFIG_LCD=y

so using y if !DM_VIDEO would disable the command for them.

> To avoid the defconfig modifications in the patch.
> (lcd.o if compiled ifndef CONFIG_DM_VIDEO) / command previously always define in this case)
> But you prefer perhaps to have clear CONFIG_CMD configuration in each defconfig.

I'd like to reduce the defconfig size, so v2 patch uses
"default y if LCD" to auto-select the command (compatibility for
existing CONFIG_LCD users). For other configurations the command
should be enabled in defconfig by users, when needed.

...
> But Ok for the rest. 
> Tested on my board (stm32mp157_ev1 with DM_VIDEO activated)
> 
> Regards, Patrick.
> 
> Tested-by: Patrick.Delaunay <patrick.delaunay@free.fr>

Thanks for testing it!

--
Anatolij