From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: bmp: manage centered display
Date: Mon, 3 Dec 2018 10:21:26 +0100 [thread overview]
Message-ID: <20181203102126.12853e81@crub> (raw)
In-Reply-To: <70aaf9daa8fa48b3af6f7fc76f72b600@SFHDAG6NODE3.st.com>
Hi Patrick,
On Mon, 3 Dec 2018 08:45:57 +0000
Patrick DELAUNAY patrick.delaunay at st.com wrote:
...
> > > +#define BMP_ALIGN_CENTER 0x7FFF
> >
> > this already exists when including splash.h, I dropped it in v2.
>
> Ok, I don't see that splash.h is included in cmd/bmp.c.
In mainline U-Boot it is included, please see [1].
> In fact I hesitate to move this define in commun bmp include
> (in include/lcd.h with bmp_display prototype for exmaple)
> to avoid a other double definition:
>
> common/lcd.c:392 #define BMP_ALIGN_CENTER 0x7FFF
> drivers/video/video_bmp.c:143:#define BMP_ALIGN_CENTER 0x7fff
> include/splash.h:78:#define BMP_ALIGN_CENTER 0x7FFF
I've sent a patch cleaning up multiple defines, please see [2].
[1] http://git.denx.de/?p=u-boot.git;a=blob;f=cmd/bmp.c;h=02bdf48b4d422ced97dea7587f07d74c0aee6d6e;hb=HEAD#l20
[2] http://patchwork.ozlabs.org/patch/1006354
--
Anatolij
prev parent reply other threads:[~2018-12-03 9:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 9:18 [U-Boot] [PATCH] cmd: bmp: manage centered display Patrick Delaunay
2018-12-01 14:06 ` Anatolij Gustschin
2018-12-03 8:45 ` Patrick DELAUNAY
2018-12-03 9:21 ` Anatolij Gustschin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203102126.12853e81@crub \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox