From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Mon, 3 Dec 2018 10:21:26 +0100 Subject: [U-Boot] [PATCH] cmd: bmp: manage centered display In-Reply-To: <70aaf9daa8fa48b3af6f7fc76f72b600@SFHDAG6NODE3.st.com> References: <1542187102-20993-1-git-send-email-patrick.delaunay@st.com> <20181201150605.1f49f173@crub> <70aaf9daa8fa48b3af6f7fc76f72b600@SFHDAG6NODE3.st.com> Message-ID: <20181203102126.12853e81@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Patrick, On Mon, 3 Dec 2018 08:45:57 +0000 Patrick DELAUNAY patrick.delaunay at st.com wrote: ... > > > +#define BMP_ALIGN_CENTER 0x7FFF > > > > this already exists when including splash.h, I dropped it in v2. > > Ok, I don't see that splash.h is included in cmd/bmp.c. In mainline U-Boot it is included, please see [1]. > In fact I hesitate to move this define in commun bmp include > (in include/lcd.h with bmp_display prototype for exmaple) > to avoid a other double definition: > > common/lcd.c:392 #define BMP_ALIGN_CENTER 0x7FFF > drivers/video/video_bmp.c:143:#define BMP_ALIGN_CENTER 0x7fff > include/splash.h:78:#define BMP_ALIGN_CENTER 0x7FFF I've sent a patch cleaning up multiple defines, please see [2]. [1] http://git.denx.de/?p=u-boot.git;a=blob;f=cmd/bmp.c;h=02bdf48b4d422ced97dea7587f07d74c0aee6d6e;hb=HEAD#l20 [2] http://patchwork.ozlabs.org/patch/1006354 -- Anatolij