From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Revert "serial: ns16550: fix debug uart putc called before init"
Date: Mon, 3 Dec 2018 23:50:09 -0500 [thread overview]
Message-ID: <20181204045009.GG5048@bill-the-cat> (raw)
In-Reply-To: <20181203205533.17629-1-simon.k.r.goldschmidt@gmail.com>
On Mon, Dec 03, 2018 at 09:55:33PM +0100, Simon Goldschmidt wrote:
> This reverts commit 6f57c34473d37b8da5e6a3764d0d377d748aeef1 since it
> does not seem to work at least on rk3399.
>
> The Rockchip Technical Reference Manual (TRM) for the rk3399 says the baud
> rate prescaler register is readable only when USR[0] is zero. Since this
> bit is defined as "reserved" in the socfpga cylcone5 TRM, let's rather
> drop this than making the ns16550 debug uart more platform specific.
>
> Reported-by: Roosen Henri <Henri.Roosen@ginzinger.com>
> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/0ed8582d/attachment.sig>
prev parent reply other threads:[~2018-12-04 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 20:55 [U-Boot] [PATCH] Revert "serial: ns16550: fix debug uart putc called before init" Simon Goldschmidt
2018-12-03 20:57 ` Philipp Tomsich
2018-12-03 21:01 ` Tom Rini
2018-12-04 2:49 ` Kever Yang
2018-12-04 4:50 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204045009.GG5048@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox