public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 2/4] ARM: vf610: ddrmc: fix CR138 preprocessor define
Date: Tue, 4 Dec 2018 11:57:25 +0100	[thread overview]
Message-ID: <20181204115725.09a691f4@jawa> (raw)
In-Reply-To: <20181204101021.22817-3-stefan@agner.ch>

Hi Stefan,

> From: Stefan Agner <stefan.agner@toradex.com>
> 
> According to the data sheet bits 10-8 are PHYDRAM_CK_EN. Fix mask
> to allow setting PHYDRAM_CK_EN correctly.
> 
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> 
>  arch/arm/include/asm/arch-vf610/imx-regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-vf610/imx-regs.h
> b/arch/arm/include/asm/arch-vf610/imx-regs.h index
> 08ba8e94f8..b7374bfb8f 100644 ---
> a/arch/arm/include/asm/arch-vf610/imx-regs.h +++
> b/arch/arm/include/asm/arch-vf610/imx-regs.h @@ -239,7 +239,7 @@
>  #define DDRMC_CR132_RDLAT_ADJ(v)			((v) & 0x3f)
>  #define DDRMC_CR137_PHYCTL_DL(v)			(((v) & 0xf)
> << 16) #define DDRMC_CR138_PHY_WRLV_MXDL(v)
> (((v) & 0xffff) << 16) -#define
> DDRMC_CR138_PHYDRAM_CK_EN(v)			(((v) & 0x8) <<
> 8) +#define DDRMC_CR138_PHYDRAM_CK_EN(v)			(((v)
> & 0x7) << 8) #define
> DDRMC_CR139_PHY_WRLV_RESPLAT(v)			(((v) & 0xff)
> << 24) #define DDRMC_CR139_PHY_WRLV_LOAD(v)
> (((v) & 0xff) << 16) #define
> DDRMC_CR139_PHY_WRLV_DLL(v)			(((v) & 0xff) << 8)

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181204/4a03f01a/attachment.sig>

  reply	other threads:[~2018-12-04 10:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 10:10 [U-Boot] [PATCH v1 0/4] ddr: vybrid: various fixes Stefan Agner
2018-12-04 10:10 ` [U-Boot] [PATCH v1 1/4] toradex: colibri_vf: fix memory initialization Stefan Agner
2018-12-04 11:05   ` Lukasz Majewski
2018-12-04 14:48     ` Stefan Agner
2018-12-04 10:10 ` [U-Boot] [PATCH v1 2/4] ARM: vf610: ddrmc: fix CR138 preprocessor define Stefan Agner
2018-12-04 10:57   ` Lukasz Majewski [this message]
2018-12-04 10:10 ` [U-Boot] [PATCH v1 3/4] ARM: vf610: ddrmc: fix initialization completion detection Stefan Agner
2018-12-04 10:59   ` Lukasz Majewski
2018-12-04 11:20     ` Stefan Agner
2018-12-14 13:22       ` Stefan Agner
2018-12-04 10:10 ` [U-Boot] [PATCH v1 4/4] ARM: vf610: ddrmc: do not write CR79 by default Stefan Agner
2018-12-04 11:00   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204115725.09a691f4@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox