From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 4/4] ARM: vf610: ddrmc: do not write CR79 by default
Date: Tue, 4 Dec 2018 12:00:44 +0100 [thread overview]
Message-ID: <20181204120044.34757608@jawa> (raw)
In-Reply-To: <20181204101021.22817-5-stefan@agner.ch>
Hi Stefan,
> From: Stefan Agner <stefan.agner@toradex.com>
>
> The current value CTLUPD_AREF(0) is the reset value of the register,
> so there is no need to write a value. If needed, the register can be
> written using board specific CR settings.
>
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
>
> arch/arm/mach-imx/ddrmc-vf610.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/ddrmc-vf610.c
> b/arch/arm/mach-imx/ddrmc-vf610.c index d121a53898..d4926b5cee 100644
> --- a/arch/arm/mach-imx/ddrmc-vf610.c
> +++ b/arch/arm/mach-imx/ddrmc-vf610.c
> @@ -188,7 +188,6 @@ void ddrmc_ctrl_init_ddr3(struct
> ddr3_jedec_timings const *timings, DDRMC_CR77_SWAP_EN,
> &ddrmr->cr[77]); writel(DDRMC_CR78_Q_FULLNESS(timings->q_fullness) |
> DDRMC_CR78_BUR_ON_FLY_BIT(12), &ddrmr->cr[78]);
> - writel(DDRMC_CR79_CTLUPD_AREF(0), &ddrmr->cr[79]);
>
> writel(DDRMC_CR82_INT_MASK, &ddrmr->cr[82]);
>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181204/3d9ad9d7/attachment.sig>
prev parent reply other threads:[~2018-12-04 11:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 10:10 [U-Boot] [PATCH v1 0/4] ddr: vybrid: various fixes Stefan Agner
2018-12-04 10:10 ` [U-Boot] [PATCH v1 1/4] toradex: colibri_vf: fix memory initialization Stefan Agner
2018-12-04 11:05 ` Lukasz Majewski
2018-12-04 14:48 ` Stefan Agner
2018-12-04 10:10 ` [U-Boot] [PATCH v1 2/4] ARM: vf610: ddrmc: fix CR138 preprocessor define Stefan Agner
2018-12-04 10:57 ` Lukasz Majewski
2018-12-04 10:10 ` [U-Boot] [PATCH v1 3/4] ARM: vf610: ddrmc: fix initialization completion detection Stefan Agner
2018-12-04 10:59 ` Lukasz Majewski
2018-12-04 11:20 ` Stefan Agner
2018-12-14 13:22 ` Stefan Agner
2018-12-04 10:10 ` [U-Boot] [PATCH v1 4/4] ARM: vf610: ddrmc: do not write CR79 by default Stefan Agner
2018-12-04 11:00 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204120044.34757608@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox