public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] cmd: bmp: manage centered display
@ 2018-12-01 13:41 Anatolij Gustschin
  2018-12-04 18:53 ` Anatolij Gustschin
  0 siblings, 1 reply; 2+ messages in thread
From: Anatolij Gustschin @ 2018-12-01 13:41 UTC (permalink / raw)
  To: u-boot

From: Patrick Delaunay <patrick.delaunay@st.com>

Allow to display BMP at the middle of the screen.

'm' means "middle" as it is done for the splashscreen variable:
splashpos=m,m

Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
---
Changes in v2:
 - drop BMP_ALIGN_CENTER define since it is already included
   with splash.h

 cmd/bmp.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/cmd/bmp.c b/cmd/bmp.c
index 02bdf48b4d..b8af784590 100644
--- a/cmd/bmp.c
+++ b/cmd/bmp.c
@@ -124,8 +124,14 @@ static int do_bmp_display(cmd_tbl_t * cmdtp, int flag, int argc, char * const ar
 		break;
 	case 4:
 		addr = simple_strtoul(argv[1], NULL, 16);
-		x = simple_strtoul(argv[2], NULL, 10);
-		y = simple_strtoul(argv[3], NULL, 10);
+		if (!strcmp(argv[2], "m"))
+			x = BMP_ALIGN_CENTER;
+		else
+			x = simple_strtoul(argv[2], NULL, 10);
+		if (!strcmp(argv[3], "m"))
+			y = BMP_ALIGN_CENTER;
+		else
+			y = simple_strtoul(argv[3], NULL, 10);
 		break;
 	default:
 		return CMD_RET_USAGE;
@@ -249,9 +255,11 @@ int bmp_display(ulong addr, int x, int y)
 	if (!ret) {
 		bool align = false;
 
-# ifdef CONFIG_SPLASH_SCREEN_ALIGN
-		align = true;
-# endif /* CONFIG_SPLASH_SCREEN_ALIGN */
+		if (CONFIG_IS_ENABLED(SPLASH_SCREEN_ALIGN) ||
+		    x == BMP_ALIGN_CENTER ||
+		    y == BMP_ALIGN_CENTER)
+			align = true;
+
 		ret = video_bmp_display(dev, addr, x, y, align);
 	}
 #elif defined(CONFIG_LCD)
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH v2] cmd: bmp: manage centered display
  2018-12-01 13:41 [U-Boot] [PATCH v2] cmd: bmp: manage centered display Anatolij Gustschin
@ 2018-12-04 18:53 ` Anatolij Gustschin
  0 siblings, 0 replies; 2+ messages in thread
From: Anatolij Gustschin @ 2018-12-04 18:53 UTC (permalink / raw)
  To: u-boot

On Sat,  1 Dec 2018 14:41:07 +0100
Anatolij Gustschin agust at denx.de wrote:

> From: Patrick Delaunay <patrick.delaunay@st.com>
> 
> Allow to display BMP at the middle of the screen.
> 
> 'm' means "middle" as it is done for the splashscreen variable:
> splashpos=m,m
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> Changes in v2:
>  - drop BMP_ALIGN_CENTER define since it is already included
>    with splash.h
> 
>  cmd/bmp.c | 18 +++++++++++++-----
>  1 file changed, 13 insertions(+), 5 deletions(-)

Applied to u-boot-video/master, thanks!

--
Anatolij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-04 18:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-01 13:41 [U-Boot] [PATCH v2] cmd: bmp: manage centered display Anatolij Gustschin
2018-12-04 18:53 ` Anatolij Gustschin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox