From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Wed, 5 Dec 2018 08:43:53 +0100
Subject: [U-Boot] [PATCH v3 07/28] mtd: ensure MTD is compiled when
 there is a SPI NOR flash using MTD
In-Reply-To: <17848047-f1b4-e698-f823-e44f9a6ee7b2@ti.com>
References: <20181204235714.11805-1-miquel.raynal@bootlin.com>
 <20181204235714.11805-8-miquel.raynal@bootlin.com>
 <17848047-f1b4-e698-f823-e44f9a6ee7b2@ti.com>
Message-ID: <20181205084353.00c11577@xps13>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi Vignesh,

Thanks for reviewing!

Vignesh R <vigneshr@ti.com> wrote on Wed, 5 Dec 2018 11:28:29 +0530:

> Hi Miquel,
>=20
> On 05/12/18 5:26 AM, Miquel Raynal wrote:
> > MTD must be enabled when there is a SPI NOR flash using the
> > SPI_FLASH_MTD config entry.
> >  =20
>=20
> I suggest to add Kconfig dependency b/w SPI_FLASH_MTD and MTD. Something =
like:
>=20
> diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
> index d735884b48db..6405fd1452d2 100644
> --- a/drivers/mtd/spi/Kconfig
> +++ b/drivers/mtd/spi/Kconfig
> @@ -144,7 +144,7 @@ config SPI_FLASH_DATAFLASH
> =20
>  config SPI_FLASH_MTD
>         bool "SPI Flash MTD support"
> -       depends on SPI_FLASH
> +       depends on SPI_FLASH && MTD
>         help
>            Enable the MTD support for spi flash layer, this adapter is for
>           translating mtd_read/mtd_write commands into spi_flash_read/wri=
te

I do agree; I could add another patch for this and also do another
check on defconfigs having SPI_FLASH_MTD and missing MTD.

Thanks,
Miqu=C3=A8l