[U-Boot] [PATCH v3 21/28] mtd: nor: NOR flashes depend on MTD

Miquel Raynal
2018-12-05T11:20:03Z

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Wed, 5 Dec 2018
11:31:44 +0100:

> On Wed, 5 Dec 2018 00:57:07 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> > A NOR flash needs the MTD core, ensure this dependency is met by
> > adding a "depends on" in Kconfig. This is fine since defconfigs have
> > been fixed.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> > drivers/mtd/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> > index 345046c2a6..0832f5b411 100644
> > --- a/drivers/mtd/Kconfig
> > +++ b/drivers/mtd/Kconfig
> > @@ -19,6 +19,7 @@ config DM_MTD
> >
> > config MTD_NOR_FLASH
> > bool "Enable parallel NOR flash support"
> > + depends on MTD
> > help
> > Enable support for parallel NOR flash.
> >
>
> Don't know if this applies here, but if you have almost all options in
> Kconfig that depend on MTD, you can add an
>
> if MTD
> endif
>
> section.

Unfortunately, not yet. There are still a lot of MTD drivers that do
not rely (at least in Kconfig) on CONFIG_MTD. This is inconsistent and
should be fixed. I don't think I will do it in this series though.

Thanks,
MiquÃ¨l