[U-Boot] [PATCH v3 26/28] cmd: make MTD commands depend on MTD

Boris Brezillon
2018-12-05T10:42:08Z

On Wed, 5 Dec 2018 00:57:12 +0100
Miquel Raynal <miquel.raynal@bootlin.com> wrote:

> Defconfigs have been fixed, now we can add proper dependencies in
> Kconfig. SPI FLASH is still not dependent on MTD (deeper rework needed).
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> cmd/Kconfig | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index cf58174013..7c166a07e6 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -679,6 +679,7 @@ config CMD_FDC
> config CMD_FLASH
> bool "flinfo, erase, protect"
> default y
> + depends on MTD
> help
> NOR flash support.
> flinfo - print FLASH memory information
> @@ -868,6 +869,7 @@ config CMD_MMC_SWRITE
>
> config CMD_MTD
> bool "mtd"
> + depends on MTD
> select MTD_PARTITIONS
> help
> MTD commands support.
> @@ -875,6 +877,7 @@ config CMD_MTD
> config CMD_NAND
> bool "nand"
> default y if NAND_SUNXI
> + depends on MTD_RAW_NAND
> help
> NAND support.
>
> @@ -915,6 +918,7 @@ config CMD_MMC_SPI
>
> config CMD_ONENAND
> bool "onenand - access to onenand device"
> + depends on MTD
> help
> OneNAND is a brand of NAND ('Not AND' gate) flash which provides
> various useful features. This command allows reading, writing,
> @@ -1733,7 +1737,7 @@ config CMD_JFFS2
>
> config CMD_MTDPARTS
> bool "MTD partition support"
> - select MTD if (CMD_NAND || NAND)
> + depends on MTD
> help
> MTD partitioning tool support.
> It is strongly encouraged to avoid using this command
> @@ -1754,14 +1758,14 @@ endif
>
> config MTDIDS_DEFAULT
> string "Default MTD IDs"
> - depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
> + depends on MTD || SPI_FLASH

Can't we have MTD enabled without MTD_PARTITIONS? I guess we don't need
to expose these options if MTD_PARTITIONS is disabled.

> help
> Defines a default MTD IDs list for use with MTD partitions in the
> Linux MTD command line partitions format.
>
> config MTDPARTS_DEFAULT
> string "Default MTD partition scheme"
> - depends on MTD_PARTITIONS || CMD_MTDPARTS || CMD_NAND || CMD_FLASH
> + depends on MTD || SPI_FLASH
> help
> Defines a default MTD partitioning scheme in the Linux MTD command
> line partitions format