From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miquel Raynal <miquel.raynal@bootlin.com>
Date: Wed, 5 Dec 2018 12:20:03 +0100
Subject: [U-Boot] [PATCH v3 21/28] mtd: nor: NOR flashes depend on MTD
In-Reply-To: <20181205113144.607c3f9a@bbrezillon>
References: <20181204235714.11805-1-miquel.raynal@bootlin.com>
 <20181204235714.11805-22-miquel.raynal@bootlin.com>
 <20181205113144.607c3f9a@bbrezillon>
Message-ID: <20181205122003.6353b3c8@xps13>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
To: u-boot@lists.denx.de

Hi Boris,

Boris Brezillon <boris.brezillon@bootlin.com> wrote on Wed, 5 Dec 2018
11:31:44 +0100:

> On Wed,  5 Dec 2018 00:57:07 +0100
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>=20
> > A NOR flash needs the MTD core, ensure this dependency is met by
> > adding a "depends on" in Kconfig. This is fine since defconfigs have
> > been fixed.
> >=20
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> > ---
> >  drivers/mtd/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/drivers/mtd/Kconfig b/drivers/mtd/Kconfig
> > index 345046c2a6..0832f5b411 100644
> > --- a/drivers/mtd/Kconfig
> > +++ b/drivers/mtd/Kconfig
> > @@ -19,6 +19,7 @@ config DM_MTD
> > =20
> >  config MTD_NOR_FLASH
> >  	bool "Enable parallel NOR flash support"
> > +	depends on MTD
> >  	help
> >  	  Enable support for parallel NOR flash.
> >   =20
>=20
> Don't know if this applies here, but if you have almost all options in
> Kconfig that depend on MTD, you can add an
>=20
> if MTD
> endif
>=20
> section.

Unfortunately, not yet. There are still a lot of MTD drivers that do
not rely (at least in Kconfig) on CONFIG_MTD. This is inconsistent and
should be fixed. I don't think I will do it in this series though.


Thanks,
Miqu=C3=A8l