From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer
Date: Thu, 6 Dec 2018 10:13:15 -0500 [thread overview]
Message-ID: <20181206151315.GV32109@bill-the-cat> (raw)
In-Reply-To: <20181206135853.9891-1-stefan@agner.ch>
On Thu, Dec 06, 2018 at 02:58:52PM +0100, Stefan Agner wrote:
> From: Stefan Agner <stefan.agner@toradex.com>
>
> Drop the statically allocated get_contents_vfatname_block and
> dynamically allocate a buffer only if required. This saves
> 64KiB of memory.
>
> Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
Is there a particular issue you're running into here, or just that what
we're doing is just generally not a great idea? I ask since I need to
poke git history to make sure that the thing at the back of my mind
about us needing to do this for some annoying boot case is intentional.
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181206/8781326a/attachment.sig>
next prev parent reply other threads:[~2018-12-06 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:58 [U-Boot] [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer Stefan Agner
2018-12-06 14:42 ` Lukasz Majewski
2018-12-06 15:13 ` Tom Rini [this message]
2018-12-06 15:45 ` Stefan Agner
2018-12-06 16:06 ` Tom Rini
2018-12-06 15:46 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206151315.GV32109@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox