* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly
@ 2018-12-06 13:53 Stefan Agner
2018-12-06 14:41 ` Lukasz Majewski
2018-12-08 16:48 ` Lukasz Majewski
0 siblings, 2 replies; 15+ messages in thread
From: Stefan Agner @ 2018-12-06 13:53 UTC (permalink / raw)
To: u-boot
From: Stefan Agner <stefan.agner@toradex.com>
The current bitmap is a bit larger than necessary, it has a black
border around the Toradex logo. Crop the logo slightly which safes
some space, useful especially on Colibri VFxx.
Signed-off-by: Stefan Agner <stefan.agner@toradex.com>
---
tools/logos/toradex.bmp | Bin 24982 -> 23298 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
diff --git a/tools/logos/toradex.bmp b/tools/logos/toradex.bmp
index 3e2dcf23358dd46fc7b1bb0dae70d3ba985606ee..8b5cb18e8475b3eda72c9f0e821b2aad17bc1bae 100644
GIT binary patch
delta 505
zcmYLEO-oxr6rCd>(HDKjZ>@>Jpis10rD|SMpO}a~;ztZ>#n#YvXDMP^LN{G at Ros~Y
z7ZzGv2rXT;2fM2V{0-tp-MG+&1*NzVD!qwH2j<L~d(J&`XLSefe<B*6D4JJ=_0FZ#
zqA&|eIdVc37wR8om8$e!Zz<*l6?djGE9YG(S~;)!9=&quRG=vfFLUm4-15 at m|9r0G
zmizeCFm60Pec_#Ey3_){ltsV`(*{R;a?MtR!GlVHyVU}jnm+JXtq3Lc0*@L5*6#@X
zZWM?FBG5Uvi_1-;;7M@9V643tT)ro*yB*RRyf5r!m%wIs7(X6Z&}P4>2dpwK^!TCA
z#vApR)u#7*|L~|!Y at L=^>|}#ZB|Th=)POrtDVzOa=q<<Og53sg4CGC*R at M$yfp)Br
zTCNWr4?o94(4CgaqoH;%G%TNcHS!SLa%5g3A at fQ&UylZ%jYNRCF+X@VE-pJ+(CWB8
zDGB)@pZ0ionrZ=CrbK@;9R;^%B+8u4K>wYo&*H6Kdi+g)O1ODE*9`if$Qv)_#k`r8
Tu-(CC?xpL%<TJT_e17>4;b52`
delta 656
zcmXw!ODIHP6vw|?uE!njFhgTzOi3nYyasb;yv8sxo^!iK9tlwv3RzGrG(|QZDZa9j
zB?~JZ+1My$i;az at WKD$CWZ~X(xb^k>&j0++`QLBjQaHR3{E^t<G{Y~D##p(2>lYa7
z)+w+|)TbsGvzX}UqTV=PO%wUG_^qEgSQ8tBeJ!7_i5^I%n~giXW{@^6RYN>W!v46l
zZnTmTwxA%p5v^)Y2)QGZeq#<|oysNFT8OjO0P4s2<a;b2$~I!OkeIL&FCDc1-KiRL
zf{70}efyfocU>k(xMn2%=P%%;Ou?--52dJHO4+QS`l^!nSw-~J;C6l%lwr~5F=qKz
zmy?(Jy*yd_Wjye{4y`=ZDsxrI1-IXU5n+X*mIJivEJ(i7hzuVMUi3JcX#IAJ8&;aF
zsBO3WN1EXwgprVHrN`B`5$D^R(R&&puNHN|Pe+lV at v!3JlZpi4&OG#JQJUH6Lh5}x
zJarfUd2L|nEy26~M84?DfS$fmoLlIpxszBE*3T+sI<+ON_XaQ<ZsTQGzYS9D9-_I)
WVdOzbgrkvqwA_u-FJz9T1ojITOUl0h
--
2.19.2
^ permalink raw reply [flat|nested] 15+ messages in thread* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-06 13:53 [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly Stefan Agner @ 2018-12-06 14:41 ` Lukasz Majewski 2018-12-08 16:48 ` Lukasz Majewski 1 sibling, 0 replies; 15+ messages in thread From: Lukasz Majewski @ 2018-12-06 14:41 UTC (permalink / raw) To: u-boot On Thu, 6 Dec 2018 14:53:02 +0100 Stefan Agner <stefan@agner.ch> wrote: > From: Stefan Agner <stefan.agner@toradex.com> > > The current bitmap is a bit larger than necessary, it has a black > border around the Toradex logo. Crop the logo slightly which safes > some space, useful especially on Colibri VFxx. > > Signed-off-by: Stefan Agner <stefan.agner@toradex.com> > --- > > tools/logos/toradex.bmp | Bin 24982 -> 23298 bytes > 1 file changed, 0 insertions(+), 0 deletions(-) > > diff --git a/tools/logos/toradex.bmp b/tools/logos/toradex.bmp > index > 3e2dcf23358dd46fc7b1bb0dae70d3ba985606ee..8b5cb18e8475b3eda72c9f0e821b2aad17bc1bae > 100644 GIT binary patch delta 505 > zcmYLEO-oxr6rCd>(HDKjZ>@>Jpis10rD|SMpO}a~;ztZ>#n#YvXDMP^LN{G at Ros~Y > z7ZzGv2rXT;2fM2V{0-tp-MG+&1*NzVD!qwH2j<L~d(J&`XLSefe<B*6D4JJ=_0FZ# > zqA&|eIdVc37wR8om8$e!Zz<*l6?djGE9YG(S~;)!9=&quRG=vfFLUm4-15@m|9r0G > zmizeCFm60Pec_#Ey3_){ltsV`(*{R;a?MtR!GlVHyVU}jnm+JXtq3Lc0*@L5*6#@X > zZWM?FBG5Uvi_1-;;7M at 9V643tT)ro*yB*RRyf5r!m%wIs7(X6Z&}P4>2dpwK^!TCA > z#vApR)u#7*|L~|!Y at L=^>|}#ZB|Th=)POrtDVzOa=q<<Og53sg4CGC*R@M$yfp)Br > zTCNWr4?o94(4CgaqoH;%G%TNcHS!SLa%5g3A at fQ&UylZ%jYNRCF+X at VE-pJ+(CWB8 > zDGB)@pZ0ionrZ=CrbK@;9R;^%B+8u4K>wYo&*H6Kdi+g)O1ODE*9`if$Qv)_#k`r8 > Tu-(CC?xpL%<TJT_e17>4;b52` > > delta 656 > zcmXw!ODIHP6vw|?uE!njFhgTzOi3nYyasb;yv8sxo^!iK9tlwv3RzGrG(|QZDZa9j > zB?~JZ+1My$i;az at WKD$CWZ~X(xb^k>&j0++`QLBjQaHR3{E^t<G{Y~D##p(2>lYa7 > z)+w+|)TbsGvzX}UqTV=PO%wUG_^qEgSQ8tBeJ!7_i5^I%n~giXW{@^6RYN>W!v46l > zZnTmTwxA%p5v^)Y2)QGZeq#<|oysNFT8OjO0P4s2<a;b2$~I!OkeIL&FCDc1-KiRL > zf{70}efyfocU>k(xMn2%=P%%;Ou?--52dJHO4+QS`l^!nSw-~J;C6l%lwr~5F=qKz > zmy?(Jy*yd_Wjye{4y`=ZDsxrI1-IXU5n+X*mIJivEJ(i7hzuVMUi3JcX#IAJ8&;aF > zsBO3WN1EXwgprVHrN`B`5$D^R(R&&puNHN|Pe+lV at v!3JlZpi4&OG#JQJUH6Lh5}x > zJarfUd2L|nEy26~M84?DfS$fmoLlIpxszBE*3T+sI<+ON_XaQ<ZsTQGzYS9D9-_I) > WVdOzbgrkvqwA_u-FJz9T1ojITOUl0h > Reviewed-by: Lukasz Majewski <lukma@denx.de> Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181206/30a4c06f/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-06 13:53 [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly Stefan Agner 2018-12-06 14:41 ` Lukasz Majewski @ 2018-12-08 16:48 ` Lukasz Majewski 2018-12-14 13:13 ` Stefan Agner 1 sibling, 1 reply; 15+ messages in thread From: Lukasz Majewski @ 2018-12-08 16:48 UTC (permalink / raw) To: u-boot Hi Stefan, > From: Stefan Agner <stefan.agner@toradex.com> > > The current bitmap is a bit larger than necessary, it has a black > border around the Toradex logo. Crop the logo slightly which safes > some space, useful especially on Colibri VFxx. I can confirm that those changes, as well as [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer Reduce the u-boot.vyb binary for colibri_vf, so it is possible to put more device tree description data to vf.dtsi and hence convert some vf610 boards to DTS/DM. Tested-by: Lukasz Majewski <lukma@denx.de> Thanks Stefan :-) > > Signed-off-by: Stefan Agner <stefan.agner@toradex.com> > --- > > tools/logos/toradex.bmp | Bin 24982 -> 23298 bytes > 1 file changed, 0 insertions(+), 0 deletions(-) > > diff --git a/tools/logos/toradex.bmp b/tools/logos/toradex.bmp > index > 3e2dcf23358dd46fc7b1bb0dae70d3ba985606ee..8b5cb18e8475b3eda72c9f0e821b2aad17bc1bae > 100644 GIT binary patch delta 505 > zcmYLEO-oxr6rCd>(HDKjZ>@>Jpis10rD|SMpO}a~;ztZ>#n#YvXDMP^LN{G at Ros~Y > z7ZzGv2rXT;2fM2V{0-tp-MG+&1*NzVD!qwH2j<L~d(J&`XLSefe<B*6D4JJ=_0FZ# > zqA&|eIdVc37wR8om8$e!Zz<*l6?djGE9YG(S~;)!9=&quRG=vfFLUm4-15@m|9r0G > zmizeCFm60Pec_#Ey3_){ltsV`(*{R;a?MtR!GlVHyVU}jnm+JXtq3Lc0*@L5*6#@X > zZWM?FBG5Uvi_1-;;7M at 9V643tT)ro*yB*RRyf5r!m%wIs7(X6Z&}P4>2dpwK^!TCA > z#vApR)u#7*|L~|!Y at L=^>|}#ZB|Th=)POrtDVzOa=q<<Og53sg4CGC*R@M$yfp)Br > zTCNWr4?o94(4CgaqoH;%G%TNcHS!SLa%5g3A at fQ&UylZ%jYNRCF+X at VE-pJ+(CWB8 > zDGB)@pZ0ionrZ=CrbK@;9R;^%B+8u4K>wYo&*H6Kdi+g)O1ODE*9`if$Qv)_#k`r8 > Tu-(CC?xpL%<TJT_e17>4;b52` > > delta 656 > zcmXw!ODIHP6vw|?uE!njFhgTzOi3nYyasb;yv8sxo^!iK9tlwv3RzGrG(|QZDZa9j > zB?~JZ+1My$i;az at WKD$CWZ~X(xb^k>&j0++`QLBjQaHR3{E^t<G{Y~D##p(2>lYa7 > z)+w+|)TbsGvzX}UqTV=PO%wUG_^qEgSQ8tBeJ!7_i5^I%n~giXW{@^6RYN>W!v46l > zZnTmTwxA%p5v^)Y2)QGZeq#<|oysNFT8OjO0P4s2<a;b2$~I!OkeIL&FCDc1-KiRL > zf{70}efyfocU>k(xMn2%=P%%;Ou?--52dJHO4+QS`l^!nSw-~J;C6l%lwr~5F=qKz > zmy?(Jy*yd_Wjye{4y`=ZDsxrI1-IXU5n+X*mIJivEJ(i7hzuVMUi3JcX#IAJ8&;aF > zsBO3WN1EXwgprVHrN`B`5$D^R(R&&puNHN|Pe+lV at v!3JlZpi4&OG#JQJUH6Lh5}x > zJarfUd2L|nEy26~M84?DfS$fmoLlIpxszBE*3T+sI<+ON_XaQ<ZsTQGzYS9D9-_I) > WVdOzbgrkvqwA_u-FJz9T1ojITOUl0h > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181208/4d575886/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-08 16:48 ` Lukasz Majewski @ 2018-12-14 13:13 ` Stefan Agner 2018-12-14 13:20 ` Tom Rini 0 siblings, 1 reply; 15+ messages in thread From: Stefan Agner @ 2018-12-14 13:13 UTC (permalink / raw) To: u-boot Hi Tom, On 08.12.2018 17:48, Lukasz Majewski wrote: > Hi Stefan, > >> From: Stefan Agner <stefan.agner@toradex.com> >> >> The current bitmap is a bit larger than necessary, it has a black >> border around the Toradex logo. Crop the logo slightly which safes >> some space, useful especially on Colibri VFxx. > > I can confirm that those changes, as well as > > [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B > [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts > [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer I think all of those go directly into your tree? -- Stefan > > Reduce the u-boot.vyb binary for colibri_vf, so it is possible to put > more device tree description data to vf.dtsi and hence convert some > vf610 boards to DTS/DM. > > Tested-by: Lukasz Majewski <lukma@denx.de> > > Thanks Stefan :-) > >> >> Signed-off-by: Stefan Agner <stefan.agner@toradex.com> >> --- >> >> tools/logos/toradex.bmp | Bin 24982 -> 23298 bytes >> 1 file changed, 0 insertions(+), 0 deletions(-) >> >> diff --git a/tools/logos/toradex.bmp b/tools/logos/toradex.bmp >> index >> 3e2dcf23358dd46fc7b1bb0dae70d3ba985606ee..8b5cb18e8475b3eda72c9f0e821b2aad17bc1bae >> 100644 GIT binary patch delta 505 >> zcmYLEO-oxr6rCd>(HDKjZ>@>Jpis10rD|SMpO}a~;ztZ>#n#YvXDMP^LN{G at Ros~Y >> z7ZzGv2rXT;2fM2V{0-tp-MG+&1*NzVD!qwH2j<L~d(J&`XLSefe<B*6D4JJ=_0FZ# >> zqA&|eIdVc37wR8om8$e!Zz<*l6?djGE9YG(S~;)!9=&quRG=vfFLUm4-15@m|9r0G >> zmizeCFm60Pec_#Ey3_){ltsV`(*{R;a?MtR!GlVHyVU}jnm+JXtq3Lc0*@L5*6#@X >> zZWM?FBG5Uvi_1-;;7M at 9V643tT)ro*yB*RRyf5r!m%wIs7(X6Z&}P4>2dpwK^!TCA >> z#vApR)u#7*|L~|!Y at L=^>|}#ZB|Th=)POrtDVzOa=q<<Og53sg4CGC*R@M$yfp)Br >> zTCNWr4?o94(4CgaqoH;%G%TNcHS!SLa%5g3A at fQ&UylZ%jYNRCF+X at VE-pJ+(CWB8 >> zDGB)@pZ0ionrZ=CrbK@;9R;^%B+8u4K>wYo&*H6Kdi+g)O1ODE*9`if$Qv)_#k`r8 >> Tu-(CC?xpL%<TJT_e17>4;b52` >> >> delta 656 >> zcmXw!ODIHP6vw|?uE!njFhgTzOi3nYyasb;yv8sxo^!iK9tlwv3RzGrG(|QZDZa9j >> zB?~JZ+1My$i;az at WKD$CWZ~X(xb^k>&j0++`QLBjQaHR3{E^t<G{Y~D##p(2>lYa7 >> z)+w+|)TbsGvzX}UqTV=PO%wUG_^qEgSQ8tBeJ!7_i5^I%n~giXW{@^6RYN>W!v46l >> zZnTmTwxA%p5v^)Y2)QGZeq#<|oysNFT8OjO0P4s2<a;b2$~I!OkeIL&FCDc1-KiRL >> zf{70}efyfocU>k(xMn2%=P%%;Ou?--52dJHO4+QS`l^!nSw-~J;C6l%lwr~5F=qKz >> zmy?(Jy*yd_Wjye{4y`=ZDsxrI1-IXU5n+X*mIJivEJ(i7hzuVMUi3JcX#IAJ8&;aF >> zsBO3WN1EXwgprVHrN`B`5$D^R(R&&puNHN|Pe+lV at v!3JlZpi4&OG#JQJUH6Lh5}x >> zJarfUd2L|nEy26~M84?DfS$fmoLlIpxszBE*3T+sI<+ON_XaQ<ZsTQGzYS9D9-_I) >> WVdOzbgrkvqwA_u-FJz9T1ojITOUl0h >> > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-14 13:13 ` Stefan Agner @ 2018-12-14 13:20 ` Tom Rini 2018-12-14 13:26 ` Stefan Agner 0 siblings, 1 reply; 15+ messages in thread From: Tom Rini @ 2018-12-14 13:20 UTC (permalink / raw) To: u-boot On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: > Hi Tom, > > On 08.12.2018 17:48, Lukasz Majewski wrote: > > Hi Stefan, > > > >> From: Stefan Agner <stefan.agner@toradex.com> > >> > >> The current bitmap is a bit larger than necessary, it has a black > >> border around the Toradex logo. Crop the logo slightly which safes > >> some space, useful especially on Colibri VFxx. > > > > I can confirm that those changes, as well as > > > > [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B > > [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts > > [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer > > I think all of those go directly into your tree? I had filed vybird stuff off to Stefano for some, hopefully correct reason. The FAT change and logo change are me, yes. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/389da121/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-14 13:20 ` Tom Rini @ 2018-12-14 13:26 ` Stefan Agner 2018-12-14 13:30 ` Tom Rini 0 siblings, 1 reply; 15+ messages in thread From: Stefan Agner @ 2018-12-14 13:26 UTC (permalink / raw) To: u-boot On 14.12.2018 14:20, Tom Rini wrote: > On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: >> Hi Tom, >> >> On 08.12.2018 17:48, Lukasz Majewski wrote: >> > Hi Stefan, >> > >> >> From: Stefan Agner <stefan.agner@toradex.com> >> >> >> >> The current bitmap is a bit larger than necessary, it has a black >> >> border around the Toradex logo. Crop the logo slightly which safes >> >> some space, useful especially on Colibri VFxx. >> > >> > I can confirm that those changes, as well as >> > >> > [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B >> > [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts >> > [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer >> >> I think all of those go directly into your tree? > > I had filed vybird stuff off to Stefano for some, hopefully correct > reason. The FAT change and logo change are me, yes. I guess the mtd change is rather global... Currently board/toradex is not specifically marked to be maintained by Stefano (we also have Tegra boards). But yeah for Vybrid it probably makes sense. -- Stefan ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-14 13:26 ` Stefan Agner @ 2018-12-14 13:30 ` Tom Rini 2018-12-14 13:40 ` Stefano Babic 0 siblings, 1 reply; 15+ messages in thread From: Tom Rini @ 2018-12-14 13:30 UTC (permalink / raw) To: u-boot On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner wrote: > On 14.12.2018 14:20, Tom Rini wrote: > > On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: > >> Hi Tom, > >> > >> On 08.12.2018 17:48, Lukasz Majewski wrote: > >> > Hi Stefan, > >> > > >> >> From: Stefan Agner <stefan.agner@toradex.com> > >> >> > >> >> The current bitmap is a bit larger than necessary, it has a black > >> >> border around the Toradex logo. Crop the logo slightly which safes > >> >> some space, useful especially on Colibri VFxx. > >> > > >> > I can confirm that those changes, as well as > >> > > >> > [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B > >> > [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts > >> > [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer > >> > >> I think all of those go directly into your tree? > > > > I had filed vybird stuff off to Stefano for some, hopefully correct > > reason. The FAT change and logo change are me, yes. > > I guess the mtd change is rather global... Ah right. Maybe I gave it to myself? I know I assigned it in patchwork. > Currently board/toradex is not specifically marked to be maintained by > Stefano (we also have Tegra boards). But yeah for Vybrid it probably > makes sense. Right, I try and assign boards based on the underlying SoC correctly but do also from time to time get them wrong (there's a handful of "wait that's not TI-based that's iMX-based, oops" I catch myself on). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/50a6aac6/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-14 13:30 ` Tom Rini @ 2018-12-14 13:40 ` Stefano Babic 2019-01-04 15:05 ` Stefan Agner 0 siblings, 1 reply; 15+ messages in thread From: Stefano Babic @ 2018-12-14 13:40 UTC (permalink / raw) To: u-boot On 14/12/18 14:30, Tom Rini wrote: > On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner wrote: >> On 14.12.2018 14:20, Tom Rini wrote: >>> On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: >>>> Hi Tom, >>>> >>>> On 08.12.2018 17:48, Lukasz Majewski wrote: >>>>> Hi Stefan, >>>>> >>>>>> From: Stefan Agner <stefan.agner@toradex.com> >>>>>> >>>>>> The current bitmap is a bit larger than necessary, it has a black >>>>>> border around the Toradex logo. Crop the logo slightly which safes >>>>>> some space, useful especially on Colibri VFxx. >>>>> >>>>> I can confirm that those changes, as well as >>>>> >>>>> [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B >>>>> [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts >>>>> [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer >>>> >>>> I think all of those go directly into your tree? >>> >>> I had filed vybird stuff off to Stefano for some, hopefully correct >>> reason. The FAT change and logo change are me, yes. >> >> I guess the mtd change is rather global... > > Ah right. Maybe I gave it to myself? I know I assigned it in > patchwork. > >> Currently board/toradex is not specifically marked to be maintained by >> Stefano (we also have Tegra boards). But yeah for Vybrid it probably >> makes sense. > Yes, I saw your patches, I will picked them up after current PR (sent now) will be merged. > Right, I try and assign boards based on the underlying SoC correctly but > do also from time to time get them wrong (there's a handful of "wait > that's not TI-based that's iMX-based, oops" I catch myself on). > Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2018-12-14 13:40 ` Stefano Babic @ 2019-01-04 15:05 ` Stefan Agner 2019-01-09 15:41 ` Stefano Babic 0 siblings, 1 reply; 15+ messages in thread From: Stefan Agner @ 2019-01-04 15:05 UTC (permalink / raw) To: u-boot Hi Stefano, On 14.12.2018 14:40, Stefano Babic wrote: > On 14/12/18 14:30, Tom Rini wrote: >> On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner wrote: >>> On 14.12.2018 14:20, Tom Rini wrote: >>>> On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: >>>>> Hi Tom, >>>>> >>>>> On 08.12.2018 17:48, Lukasz Majewski wrote: >>>>>> Hi Stefan, >>>>>> >>>>>>> From: Stefan Agner <stefan.agner@toradex.com> >>>>>>> >>>>>>> The current bitmap is a bit larger than necessary, it has a black >>>>>>> border around the Toradex logo. Crop the logo slightly which safes >>>>>>> some space, useful especially on Colibri VFxx. >>>>>> >>>>>> I can confirm that those changes, as well as >>>>>> >>>>>> [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B >>>>>> [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts >>>>>> [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer >>>>> >>>>> I think all of those go directly into your tree? >>>> >>>> I had filed vybird stuff off to Stefano for some, hopefully correct >>>> reason. The FAT change and logo change are me, yes. >>> >>> I guess the mtd change is rather global... >> >> Ah right. Maybe I gave it to myself? I know I assigned it in >> patchwork. >> >>> Currently board/toradex is not specifically marked to be maintained by >>> Stefano (we also have Tegra boards). But yeah for Vybrid it probably >>> makes sense. >> > > Yes, I saw your patches, I will picked them up after current PR (sent > now) will be merged. This still did not make it. Can it still be considered for the next release? There is also: - board: toradex: colibri_vf: unset NFS and LOADS/B - ARM: vf610: ddrmc: program Dummy DDRBYTE1/2 - ddr: vybrid: various fixes (patchset) -- Stefan > >> Right, I try and assign boards based on the underlying SoC correctly but >> do also from time to time get them wrong (there's a handful of "wait >> that's not TI-based that's iMX-based, oops" I catch myself on). >> > > Regards, > Stefano ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2019-01-04 15:05 ` Stefan Agner @ 2019-01-09 15:41 ` Stefano Babic 2019-01-09 21:38 ` Lukasz Majewski 0 siblings, 1 reply; 15+ messages in thread From: Stefano Babic @ 2019-01-09 15:41 UTC (permalink / raw) To: u-boot Hi Stefan, Lukasz, On 04/01/19 16:05, Stefan Agner wrote: > Hi Stefano, > > On 14.12.2018 14:40, Stefano Babic wrote: >> On 14/12/18 14:30, Tom Rini wrote: >>> On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner wrote: >>>> On 14.12.2018 14:20, Tom Rini wrote: >>>>> On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: >>>>>> Hi Tom, >>>>>> >>>>>> On 08.12.2018 17:48, Lukasz Majewski wrote: >>>>>>> Hi Stefan, >>>>>>> >>>>>>>> From: Stefan Agner <stefan.agner@toradex.com> >>>>>>>> >>>>>>>> The current bitmap is a bit larger than necessary, it has a black >>>>>>>> border around the Toradex logo. Crop the logo slightly which safes >>>>>>>> some space, useful especially on Colibri VFxx. >>>>>>> >>>>>>> I can confirm that those changes, as well as >>>>>>> >>>>>>> [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B You're right, this was slipped away, I pick it now. >>>>>>> [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC layouts >>>>>>> [PATCH v1] fs: fat: dynamically allocate memory for temporary buffer Both of them are outside u-boot-imx, so they will be merged by Scott / Tom. >>>>>> >>>>>> I think all of those go directly into your tree? >>>>> >>>>> I had filed vybird stuff off to Stefano for some, hopefully correct >>>>> reason. The FAT change and logo change are me, yes. >>>> >>>> I guess the mtd change is rather global... >>> >>> Ah right. Maybe I gave it to myself? I know I assigned it in >>> patchwork. >>> >>>> Currently board/toradex is not specifically marked to be maintained by >>>> Stefano (we also have Tegra boards). But yeah for Vybrid it probably >>>> makes sense. >>> >> >> Yes, I saw your patches, I will picked them up after current PR (sent >> now) will be merged. > > This still did not make it. Can it still be considered for the next > release? > > There is also: > - board: toradex: colibri_vf: unset NFS and LOADS/B > - ARM: vf610: ddrmc: program Dummy DDRBYTE1/2 Applied to u-boot-imx. > - ddr: vybrid: various fixes (patchset) There is a (slight) conflict with Lukasz's patches regarding DDR calibration. I won't pick Lukasz's for 2019.01, and I could solve the conflict in -next branch. IMHO I have no concerns (open points) regarding usage of bit shifting instead of BIT() macro. So I pushed this patchset and I delay Lukasz's to next release. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2019-01-09 15:41 ` Stefano Babic @ 2019-01-09 21:38 ` Lukasz Majewski 2019-01-10 8:15 ` Stefano Babic 0 siblings, 1 reply; 15+ messages in thread From: Lukasz Majewski @ 2019-01-09 21:38 UTC (permalink / raw) To: u-boot On Wed, 9 Jan 2019 16:41:40 +0100 Stefano Babic <sbabic@denx.de> wrote: > Hi Stefan, Lukasz, > > On 04/01/19 16:05, Stefan Agner wrote: > > Hi Stefano, > > > > On 14.12.2018 14:40, Stefano Babic wrote: > >> On 14/12/18 14:30, Tom Rini wrote: > >>> On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner wrote: > >>>> On 14.12.2018 14:20, Tom Rini wrote: > >>>>> On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: > >>>>>> Hi Tom, > >>>>>> > >>>>>> On 08.12.2018 17:48, Lukasz Majewski wrote: > >>>>>>> Hi Stefan, > >>>>>>> > >>>>>>>> From: Stefan Agner <stefan.agner@toradex.com> > >>>>>>>> > >>>>>>>> The current bitmap is a bit larger than necessary, it has a > >>>>>>>> black border around the Toradex logo. Crop the logo slightly > >>>>>>>> which safes some space, useful especially on Colibri VFxx. > >>>>>>> > >>>>>>> I can confirm that those changes, as well as > >>>>>>> > >>>>>>> [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B > > You're right, this was slipped away, I pick it now. > > >>>>>>> [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC > >>>>>>> layouts [PATCH v1] fs: fat: dynamically allocate memory for > >>>>>>> temporary buffer > > Both of them are outside u-boot-imx, so they will be merged by > Scott / Tom. > > >>>>>> > >>>>>> I think all of those go directly into your tree? > >>>>> > >>>>> I had filed vybird stuff off to Stefano for some, hopefully > >>>>> correct reason. The FAT change and logo change are me, yes. > >>>> > >>>> I guess the mtd change is rather global... > >>> > >>> Ah right. Maybe I gave it to myself? I know I assigned it in > >>> patchwork. > >>> > >>>> Currently board/toradex is not specifically marked to be > >>>> maintained by Stefano (we also have Tegra boards). But yeah for > >>>> Vybrid it probably makes sense. > >>> > >> > >> Yes, I saw your patches, I will picked them up after current PR > >> (sent now) will be merged. > > > > This still did not make it. Can it still be considered for the next > > release? > > > > There is also: > > - board: toradex: colibri_vf: unset NFS and LOADS/B > > - ARM: vf610: ddrmc: program Dummy DDRBYTE1/2 > > Applied to u-boot-imx. > > > - ddr: vybrid: various fixes (patchset) > > There is a (slight) conflict with Lukasz's patches regarding DDR > calibration. I won't pick Lukasz's for 2019.01, Ok. No problem. ( The DDR patch series itself: http://patchwork.ozlabs.org/cover/1008330/) > and I could solve the > conflict in -next branch. IMHO I have no concerns (open points) > regarding usage of bit shifting instead of BIT() macro. So I pushed > this patchset and I delay Lukasz's to next release. Ok. Thanks for the update. > > Best regards, > Stefano > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190109/c47e3549/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2019-01-09 21:38 ` Lukasz Majewski @ 2019-01-10 8:15 ` Stefano Babic 2019-01-10 9:29 ` Lukasz Majewski 0 siblings, 1 reply; 15+ messages in thread From: Stefano Babic @ 2019-01-10 8:15 UTC (permalink / raw) To: u-boot On 09/01/19 22:38, Lukasz Majewski wrote: > On Wed, 9 Jan 2019 16:41:40 +0100 > Stefano Babic <sbabic@denx.de> wrote: > >> Hi Stefan, Lukasz, >> >> On 04/01/19 16:05, Stefan Agner wrote: >>> Hi Stefano, >>> >>> On 14.12.2018 14:40, Stefano Babic wrote: >>>> On 14/12/18 14:30, Tom Rini wrote: >>>>> On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner wrote: >>>>>> On 14.12.2018 14:20, Tom Rini wrote: >>>>>>> On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner wrote: >>>>>>>> Hi Tom, >>>>>>>> >>>>>>>> On 08.12.2018 17:48, Lukasz Majewski wrote: >>>>>>>>> Hi Stefan, >>>>>>>>> >>>>>>>>>> From: Stefan Agner <stefan.agner@toradex.com> >>>>>>>>>> >>>>>>>>>> The current bitmap is a bit larger than necessary, it has a >>>>>>>>>> black border around the Toradex logo. Crop the logo slightly >>>>>>>>>> which safes some space, useful especially on Colibri VFxx. >>>>>>>>> >>>>>>>>> I can confirm that those changes, as well as >>>>>>>>> >>>>>>>>> [PATCH v1] board: toradex: colibri_vf: unset NFS and LOADS/B >> >> You're right, this was slipped away, I pick it now. >> >>>>>>>>> [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC >>>>>>>>> layouts [PATCH v1] fs: fat: dynamically allocate memory for >>>>>>>>> temporary buffer >> >> Both of them are outside u-boot-imx, so they will be merged by >> Scott / Tom. >> >>>>>>>> >>>>>>>> I think all of those go directly into your tree? >>>>>>> >>>>>>> I had filed vybird stuff off to Stefano for some, hopefully >>>>>>> correct reason. The FAT change and logo change are me, yes. >>>>>> >>>>>> I guess the mtd change is rather global... >>>>> >>>>> Ah right. Maybe I gave it to myself? I know I assigned it in >>>>> patchwork. >>>>> >>>>>> Currently board/toradex is not specifically marked to be >>>>>> maintained by Stefano (we also have Tegra boards). But yeah for >>>>>> Vybrid it probably makes sense. >>>>> >>>> >>>> Yes, I saw your patches, I will picked them up after current PR >>>> (sent now) will be merged. >>> >>> This still did not make it. Can it still be considered for the next >>> release? >>> >>> There is also: >>> - board: toradex: colibri_vf: unset NFS and LOADS/B >>> - ARM: vf610: ddrmc: program Dummy DDRBYTE1/2 >> >> Applied to u-boot-imx. >> >>> - ddr: vybrid: various fixes (patchset) >> >> There is a (slight) conflict with Lukasz's patches regarding DDR >> calibration. I won't pick Lukasz's for 2019.01, > > Ok. No problem. > ( The DDR patch series itself: > http://patchwork.ozlabs.org/cover/1008330/) > There is a topic I would like to check. Stefan introduces with his patches a DDRMC_CR80_MC_INIT_COMPLETE that is still missing in your patches. I solved the conflict (not yet pushed to -next) as : while (!(readl(&ddrmr->cr[80]) & DDRMC_CR80_MC_INIT_COMPLETE)) udelay(10); writel(DDRMC_CR80_MC_INIT_COMPLETE, &ddrmr->cr[81]); #ifdef CONFIG_DDRMC_VF610_CALIBRATION ddrmc_calibration(ddrmr); #endif But I have no idea if DDRMC_CR80_MC_INIT_COMPLETE should be done before the calibration of maybe after. Could you help me ? >> and I could solve the >> conflict in -next branch. IMHO I have no concerns (open points) >> regarding usage of bit shifting instead of BIT() macro. So I pushed >> this patchset and I delay Lukasz's to next release. > > Ok. Thanks for the update. > Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2019-01-10 8:15 ` Stefano Babic @ 2019-01-10 9:29 ` Lukasz Majewski 2019-01-10 9:34 ` Stefano Babic 0 siblings, 1 reply; 15+ messages in thread From: Lukasz Majewski @ 2019-01-10 9:29 UTC (permalink / raw) To: u-boot Hi Stefano, > On 09/01/19 22:38, Lukasz Majewski wrote: > > On Wed, 9 Jan 2019 16:41:40 +0100 > > Stefano Babic <sbabic@denx.de> wrote: > > > >> Hi Stefan, Lukasz, > >> > >> On 04/01/19 16:05, Stefan Agner wrote: > >>> Hi Stefano, > >>> > >>> On 14.12.2018 14:40, Stefano Babic wrote: > >>>> On 14/12/18 14:30, Tom Rini wrote: > >>>>> On Fri, Dec 14, 2018 at 02:26:22PM +0100, Stefan Agner > >>>>> wrote: > >>>>>> On 14.12.2018 14:20, Tom Rini wrote: > >>>>>>> On Fri, Dec 14, 2018 at 02:13:46PM +0100, Stefan Agner > >>>>>>> wrote: > >>>>>>>> Hi Tom, > >>>>>>>> > >>>>>>>> On 08.12.2018 17:48, Lukasz Majewski wrote: > >>>>>>>>> Hi Stefan, > >>>>>>>>> > >>>>>>>>>> From: Stefan Agner <stefan.agner@toradex.com> > >>>>>>>>>> > >>>>>>>>>> The current bitmap is a bit larger than necessary, it has a > >>>>>>>>>> black border around the Toradex logo. Crop the logo > >>>>>>>>>> slightly which safes some space, useful especially on > >>>>>>>>>> Colibri VFxx. > >>>>>>>>> > >>>>>>>>> I can confirm that those changes, as well as > >>>>>>>>> > >>>>>>>>> [PATCH v1] board: toradex: colibri_vf: unset NFS and > >>>>>>>>> LOADS/B > >> > >> You're right, this was slipped away, I pick it now. > >> > >>>>>>>>> [PATCH v1] mtd: nand: raw: allow to disable unneeded ECC > >>>>>>>>> layouts [PATCH v1] fs: fat: dynamically allocate memory for > >>>>>>>>> temporary buffer > >> > >> Both of them are outside u-boot-imx, so they will be merged by > >> Scott / Tom. > >> > >>>>>>>> > >>>>>>>> I think all of those go directly into your tree? > >>>>>>> > >>>>>>> I had filed vybird stuff off to Stefano for some, hopefully > >>>>>>> correct reason. The FAT change and logo change are me, > >>>>>>> yes. > >>>>>> > >>>>>> I guess the mtd change is rather global... > >>>>> > >>>>> Ah right. Maybe I gave it to myself? I know I assigned it in > >>>>> patchwork. > >>>>> > >>>>>> Currently board/toradex is not specifically marked to be > >>>>>> maintained by Stefano (we also have Tegra boards). But yeah for > >>>>>> Vybrid it probably makes sense. > >>>>> > >>>> > >>>> Yes, I saw your patches, I will picked them up after current PR > >>>> (sent now) will be merged. > >>> > >>> This still did not make it. Can it still be considered for the > >>> next release? > >>> > >>> There is also: > >>> - board: toradex: colibri_vf: unset NFS and LOADS/B > >>> - ARM: vf610: ddrmc: program Dummy DDRBYTE1/2 > >> > >> Applied to u-boot-imx. > >> > >>> - ddr: vybrid: various fixes (patchset) > >> > >> There is a (slight) conflict with Lukasz's patches regarding DDR > >> calibration. I won't pick Lukasz's for 2019.01, > > > > Ok. No problem. > > ( The DDR patch series itself: > > http://patchwork.ozlabs.org/cover/1008330/) > > > > There is a topic I would like to check. Stefan introduces with his > patches a DDRMC_CR80_MC_INIT_COMPLETE that is still missing in your > patches. I solved the conflict (not yet pushed to -next) as : > > while (!(readl(&ddrmr->cr[80]) & DDRMC_CR80_MC_INIT_COMPLETE)) > udelay(10); > writel(DDRMC_CR80_MC_INIT_COMPLETE, &ddrmr->cr[81]); > > #ifdef CONFIG_DDRMC_VF610_CALIBRATION > ddrmc_calibration(ddrmr); > #endif > > But I have no idea if DDRMC_CR80_MC_INIT_COMPLETE should be done > before the calibration of maybe after. Could you help me ? I've already rebased (DDR calibration code) on top of Stefan's patches: http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=shortlog;h=refs/heads/testing The code in question looks like in below link: http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=blob;f=arch/arm/mach-imx/ddrmc-vf610.c;h=9a8e2f6aad10adc45fa791d24ffad52c42c5c492;hb=refs/heads/testing#l231 > > >> and I could solve the > >> conflict in -next branch. IMHO I have no concerns (open points) > >> regarding usage of bit shifting instead of BIT() macro. So I pushed > >> this patchset and I delay Lukasz's to next release. > > > > Ok. Thanks for the update. > > > > Best regards, > Stefano > > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190110/55e8ebee/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2019-01-10 9:29 ` Lukasz Majewski @ 2019-01-10 9:34 ` Stefano Babic 2019-01-10 9:47 ` Lukasz Majewski 0 siblings, 1 reply; 15+ messages in thread From: Stefano Babic @ 2019-01-10 9:34 UTC (permalink / raw) To: u-boot Hi Lukasz, On 10/01/19 10:29, Lukasz Majewski wrote: > Hi Stefano, > [snip] >> There is a topic I would like to check. Stefan introduces with his >> patches a DDRMC_CR80_MC_INIT_COMPLETE that is still missing in your >> patches. I solved the conflict (not yet pushed to -next) as : >> >> while (!(readl(&ddrmr->cr[80]) & DDRMC_CR80_MC_INIT_COMPLETE)) >> udelay(10); >> writel(DDRMC_CR80_MC_INIT_COMPLETE, &ddrmr->cr[81]); >> >> #ifdef CONFIG_DDRMC_VF610_CALIBRATION >> ddrmc_calibration(ddrmr); >> #endif >> >> But I have no idea if DDRMC_CR80_MC_INIT_COMPLETE should be done >> before the calibration of maybe after. Could you help me ? > > I've already rebased (DDR calibration code) on top of Stefan's patches: > > http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=shortlog;h=refs/heads/testing > > The code in question looks like in below link: > http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=blob;f=arch/arm/mach-imx/ddrmc-vf610.c;h=9a8e2f6aad10adc45fa791d24ffad52c42c5c492;hb=refs/heads/testing#l231 ok, thanks - so the DDRMC_CR80_MC_INIT_COMPLETE is called before calibration. I have already did this by rebasing myself. There is no need you repost, I have merged yours patches into my -next branch. Regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de ===================================================================== ^ permalink raw reply [flat|nested] 15+ messages in thread
* [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly 2019-01-10 9:34 ` Stefano Babic @ 2019-01-10 9:47 ` Lukasz Majewski 0 siblings, 0 replies; 15+ messages in thread From: Lukasz Majewski @ 2019-01-10 9:47 UTC (permalink / raw) To: u-boot On Thu, 10 Jan 2019 10:34:21 +0100 Stefano Babic <sbabic@denx.de> wrote: > Hi Lukasz, > > On 10/01/19 10:29, Lukasz Majewski wrote: > > Hi Stefano, > > > > [snip] > > >> There is a topic I would like to check. Stefan introduces with his > >> patches a DDRMC_CR80_MC_INIT_COMPLETE that is still missing in your > >> patches. I solved the conflict (not yet pushed to -next) as : > >> > >> while (!(readl(&ddrmr->cr[80]) & DDRMC_CR80_MC_INIT_COMPLETE)) > >> udelay(10); > >> writel(DDRMC_CR80_MC_INIT_COMPLETE, &ddrmr->cr[81]); > >> > >> #ifdef CONFIG_DDRMC_VF610_CALIBRATION > >> ddrmc_calibration(ddrmr); > >> #endif > >> > >> But I have no idea if DDRMC_CR80_MC_INIT_COMPLETE should be done > >> before the calibration of maybe after. Could you help me ? > > > > I've already rebased (DDR calibration code) on top of Stefan's > > patches: > > > > http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=shortlog;h=refs/heads/testing > > > > The code in question looks like in below link: > > http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=blob;f=arch/arm/mach-imx/ddrmc-vf610.c;h=9a8e2f6aad10adc45fa791d24ffad52c42c5c492;hb=refs/heads/testing#l231 > > ok, thanks - so the DDRMC_CR80_MC_INIT_COMPLETE is called before > calibration. I have already did this by rebasing myself. There is no > need you repost, I have merged yours patches into my -next branch. > Thanks :-) (And I do have more vf610 patches in the queue to move it to DM - as it uses only single u-boot binary). I will post them when we release v2019.01 > Regards, > Stefano > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190110/262ab093/attachment.sig> ^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-01-10 9:47 UTC | newest] Thread overview: 15+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-12-06 13:53 [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly Stefan Agner 2018-12-06 14:41 ` Lukasz Majewski 2018-12-08 16:48 ` Lukasz Majewski 2018-12-14 13:13 ` Stefan Agner 2018-12-14 13:20 ` Tom Rini 2018-12-14 13:26 ` Stefan Agner 2018-12-14 13:30 ` Tom Rini 2018-12-14 13:40 ` Stefano Babic 2019-01-04 15:05 ` Stefan Agner 2019-01-09 15:41 ` Stefano Babic 2019-01-09 21:38 ` Lukasz Majewski 2019-01-10 8:15 ` Stefano Babic 2019-01-10 9:29 ` Lukasz Majewski 2019-01-10 9:34 ` Stefano Babic 2019-01-10 9:47 ` Lukasz Majewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox