From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 6 Dec 2018 20:19:36 -0500 Subject: [U-Boot] [U-Boot, PATCHv3, 2/4] dm: MIGRATION: Add migration plan for DM_USB In-Reply-To: References: <1543533674-8688-2-git-send-email-trini@konsulko.com> <20181204044925.GC5048@bill-the-cat> <20181205122308.GG32109@bill-the-cat> Message-ID: <20181207011936.GA14374@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Fri, Dec 07, 2018 at 01:05:24PM +1300, Chris Packham wrote: > On Thu, Dec 6, 2018 at 1:23 AM Tom Rini wrote: > > > > On Wed, Dec 05, 2018 at 08:14:14AM +0100, Stefan Roese wrote: > > > Hi Tom, > > > > > > On 04.12.18 05:49, Tom Rini wrote: > > > >On Thu, Nov 29, 2018 at 06:21:12PM -0500, Tom Rini wrote: > > > > > > > >>As much of the USB system has been migrated to DM now, formalize a > > > >>deadline for migration. > > > >> > > > >>Reviewed-by: Marek Vasut > > > >>Reviewed-by: Simon Glass > > > >>Signed-off-by: Tom Rini > > > > > > > >Applied to u-boot/master, thanks! > > > > > > Just a quick note on this, since I just tested compiling current > > > mainline on MVEBU "theadorable_debug". Here I get: > > > > > > ===================== WARNING ====================== > > > This board does not use CONFIG_DM_USB. Please update > > > the board to use CONFIG_DM_USB before the v2019.07 release. > > > Failure to update by the deadline may result in board removal. > > > See doc/driver-model/MIGRATION.txt for more info. > > > ==================================================== > > > ===================== WARNING ====================== > > > This board does not use CONFIG_DM_SCSI. Please update > > > the storage controller to use CONFIG_DM_SCSI before the v2019.07 release. > > > Failure to update by the deadline may result in board removal. > > > See doc/driver-model/MIGRATION.txt for more info. > > > ==================================================== > > > > > > The DM_SCSI warning seems to be okay, because of the not converted > > > ATA driver sata_mv.c (the controller is unfortunately not AHCI > > > compatible). I hope to find some time shortly to work on this. > > > > > > But the board definitely uses DM_USB: > > > > > > $ gg DM_USB configs/theadorable_debug_defconfig > > > configs/theadorable_debug_defconfig:CONFIG_DM_USB=y > > > > > > So the DM_USB warning seems to be wrong here. > > > > I think you're "stuck" here because you can't turn on CONFIG_BLK to > > silence the CONFIG_DM_USB warning without then breaking sata_mv.c. The > > CONFIG_DM_USB migration isn't complete until you're also using > > CONFIG_BLK. > > On a related note. I'm looking at adding a new board and have > CONFIG_DM_USB and CONFIG_USB_STORAGE enabled but I trip over the same > warning. This board doesn't enable SATA so I'm not trapped like the > theadorable boards but enabling CONFIG_BLK just to silence the warning > seems a bit wrong. Am I missing something? No, enabling CONFIG_BLK is what's needed. We can't select/depend on it in all cases that we would like yet but enabling it enables other functionality. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: