From: Derald D. Woods <woods.technical@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: at91: Fix 'boot.bin' generation when CONFIG_SD_BOOT is enabled
Date: Sat, 8 Dec 2018 13:49:05 -0600 [thread overview]
Message-ID: <20181208194905.21014-1-woods.technical@gmail.com> (raw)
In-Reply-To: <F4BAE807-3489-4F6A-9F05-F6023E3DF8D2@gmail.com>
On AT91 platforms configured for SD_BOOT, this commit avoids the
generation of the PMECC header used for booting from NAND flash. This
issue was found by attempting to boot the SAMA5D3-XPLD board with the
'sama5d3_xplained_mmc_defconfig'.
[PMECC Reference]
http://www.at91.com/linux4sam/bin/view/Linux4SAM/AT91Bootstrap
[Mailing List Thread]
https://lists.denx.de/pipermail/u-boot/2018-December/350666.html
Fixes: 5541543f ("configs: at91: Remove CONFIG_SYS_EXTRA_OPTIONS assignment")
Reported-by: Daniel Evans <photonthunder@gmail.com>
Cc: Robert Nelson <robertcnelson@gmail.com>
Cc: Eugen Hristev <eugen.hristev@microchip.com>
Cc: Wenyou Yang <wenyou.yang@microchip.com>
Signed-off-by: Derald D. Woods <woods.technical@gmail.com>
---
scripts/Makefile.spl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/scripts/Makefile.spl b/scripts/Makefile.spl
index 22bd8f7c27..e727cb610f 100644
--- a/scripts/Makefile.spl
+++ b/scripts/Makefile.spl
@@ -166,10 +166,12 @@ ifeq ($(CONFIG_SYS_SOC),"at91")
MKIMAGEFLAGS_boot.bin = -T atmelimage
ifeq ($(CONFIG_SPL_GENERATE_ATMEL_PMECC_HEADER),y)
+ifneq ($(CONFIG_SD_BOOT),y)
MKIMAGEFLAGS_boot.bin += -n $(shell $(obj)/../tools/atmel_pmecc_params)
boot.bin: $(obj)/../tools/atmel_pmecc_params
endif
+endif
boot.bin: $(obj)/u-boot-spl.bin FORCE
$(call if_changed,mkimage)
--
2.19.2
next prev parent reply other threads:[~2018-12-08 19:49 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 0:15 [U-Boot] boot.bin on SD Card for SAMA5D3 Xplained Daniel Evans
2018-12-05 14:36 ` Eugen.Hristev at microchip.com
2018-12-05 18:08 ` Daniel Evans
2018-12-05 20:38 ` Robert Nelson
2018-12-06 8:02 ` Eugen.Hristev at microchip.com
2018-12-08 2:37 ` Derald D. Woods
2018-12-08 19:49 ` Derald D. Woods [this message]
2018-12-10 8:32 ` [U-Boot] [PATCH] ARM: at91: Fix 'boot.bin' generation when CONFIG_SD_BOOT is enabled Eugen.Hristev at microchip.com
2018-12-10 13:01 ` Derald D. Woods
2018-12-10 14:03 ` Eugen.Hristev at microchip.com
2018-12-10 14:54 ` Derald Woods
2018-12-10 15:14 ` Eugen.Hristev at microchip.com
2018-12-11 5:48 ` Derald D. Woods
2018-12-15 7:36 ` [U-Boot] [PATCH] ARM: at91: Convert SPL_GENERATE_ATMEL_PMECC_HEADER to Kconfig Derald D. Woods
2018-12-28 0:04 ` Derald Woods
2019-01-07 9:40 ` Eugen.Hristev at microchip.com
2019-01-10 1:00 ` Derald Woods
2019-01-11 11:27 ` Eugen.Hristev at microchip.com
2019-01-11 16:51 ` Derald Woods
2019-01-11 16:53 ` Derald Woods
2019-01-18 8:37 ` Eugen.Hristev at microchip.com
2019-01-19 3:26 ` Derald D. Woods
2019-01-19 20:02 ` [U-Boot] [PATCH 0/2] ARM: at91: NAND PMECC Kconfig conversion Derald D. Woods
2019-01-19 20:02 ` [U-Boot] [PATCH 1/2] nand: atmel: Replace SYS_NAND_ECC_BASE with ATMEL_BASE_ECC Derald D. Woods
2019-01-19 20:02 ` [U-Boot] [PATCH 2/2] ARM: at91: Convert SPL_GENERATE_ATMEL_PMECC_HEADER to Kconfig Derald D. Woods
2019-01-19 23:29 ` [U-Boot] [PATCH 0/2] ARM: at91: NAND PMECC Kconfig conversion Tom Rini
2019-01-20 0:50 ` Derald Woods
2019-01-20 3:37 ` [U-Boot] [PATCH v2 0/1] " Derald D. Woods
2019-01-20 3:37 ` [U-Boot] [PATCH v3 1/1] ARM: at91: Convert SPL_GENERATE_ATMEL_PMECC_HEADER to Kconfig Derald D. Woods
2019-01-20 12:57 ` Tom Rini
2019-01-20 14:25 ` Derald Woods
2019-01-21 16:58 ` [U-Boot] " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208194905.21014-1-woods.technical@gmail.com \
--to=woods.technical@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox