[U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs

[Tom Rini <trini@konsulko.com>]

On Mon, Dec 10, 2018 at 01:38:36AM +0100, Philipp Tomsich wrote:
> Tom,
> 
> On 10.12.2018, at 01:28, Tom Rini <trini@konsulko.com> wrote:
> > 
> > On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> >>> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> >>> fdt relocation, so the initramfs works out of box.
> >>> 
> >>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >>> ---
> >>> 
> >>> include/configs/rv1108_common.h | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>> 
> >> 
> >> Applied to u-boot-rockchip, thanks!
> > 
> > Ugh, sorry for not spotting this sooner.  Please don't disable
> > fdt/initrd relocation and instead use bootm_size.
> 
> Thanks for spotting this (just in time).
> I’ll drop it and rerun Travis for tomorrow’s PR.

Thanks.  And you might want to audit the rest of rockchip (and no, my
own house isn't 100% in order) as it looks like in general at least
you're using fdt_high to (good) set an upper bound but I think
bootm_size is more robust as we can set that and it covers fdt and
initrd if present (which not all rk3xxx_common.h are setting).

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181209/0f6708ee/attachment.sig>