public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/7] dfu: sf: Read default speed and mode values from DT
Date: Mon, 10 Dec 2018 12:22:47 +0100	[thread overview]
Message-ID: <20181210122247.7983c568@jawa> (raw)
In-Reply-To: <1544439166-5749-5-git-send-email-patrick.delaunay@st.com>

On Mon, 10 Dec 2018 11:52:43 +0100
Patrick Delaunay <patrick.delaunay@st.com> wrote:

> In case of DT boot, don't read default speed and mode for SPI from
> CONFIG_*, instead read from DT node.
> 
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
> 
>  drivers/dfu/dfu_sf.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c
> index 066e767..5e32f80 100644
> --- a/drivers/dfu/dfu_sf.c
> +++ b/drivers/dfu/dfu_sf.c
> @@ -69,11 +69,17 @@ static struct spi_flash *parse_dev(char *devstr)
>  {
>  	unsigned int bus;
>  	unsigned int cs;
> -	unsigned int speed = CONFIG_SF_DEFAULT_SPEED;
> -	unsigned int mode = CONFIG_SF_DEFAULT_MODE;
> +	/* In DM mode, defaults will be taken from DT */
> +	unsigned int speed = 0;
> +	unsigned int mode = 0;
>  	char *s, *endp;
>  	struct spi_flash *dev;
>  
> +#ifndef CONFIG_DM_SPI_FLASH
> +	speed = CONFIG_SF_DEFAULT_SPEED;
> +	mode = CONFIG_SF_DEFAULT_MODE;
> +#endif
> +
>  	s = strsep(&devstr, ":");
>  	if (!s || !*s || (bus = simple_strtoul(s, &endp, 0), *endp))
> { printf("Invalid SPI bus %s\n", s);

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181210/0cbb7b5b/attachment.sig>

  reply	other threads:[~2018-12-10 11:22 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 10:52 [U-Boot] [PATCH 0/7] Remove defines for SPI default speed and mode Patrick Delaunay
2018-12-10 10:52 ` [U-Boot] [PATCH 1/7] spi: update management of " Patrick Delaunay
2018-12-10 11:24   ` Simon Goldschmidt
2018-12-10 20:49     ` Petr Vorel
2018-12-10 20:57       ` Simon Goldschmidt
2018-12-12 19:58   ` Jagan Teki
2018-12-10 10:52 ` [U-Boot] [PATCH 2/7] spi: add comment for spi_flash_probe_bus_cs function Patrick Delaunay
2018-12-10 11:25   ` Simon Goldschmidt
2018-12-10 20:54     ` Petr Vorel
2018-12-10 10:52 ` [U-Boot] [PATCH 3/7] da850evm: sf: Read default speed and mode values from DT Patrick Delaunay
2018-12-10 20:57   ` Petr Vorel
2018-12-12 20:02   ` Jagan Teki
2018-12-13 14:54     ` Patrick DELAUNAY
2018-12-10 10:52 ` [U-Boot] [PATCH 4/7] dfu: " Patrick Delaunay
2018-12-10 11:22   ` Lukasz Majewski [this message]
2018-12-10 21:00   ` Petr Vorel
2018-12-10 10:52 ` [U-Boot] [PATCH 5/7] mips: mt76xx: gardena-smart-gateway: " Patrick Delaunay
2018-12-10 11:47   ` Stefan Roese
2018-12-10 21:01   ` Petr Vorel
2018-12-10 10:52 ` [U-Boot] [PATCH 6/7] env: " Patrick Delaunay
2018-12-10 11:23   ` Lukasz Majewski
2018-12-10 11:27   ` Simon Goldschmidt
2018-12-10 21:08   ` Petr Vorel
2018-12-12 20:07   ` Jagan Teki
2018-12-10 10:52 ` [U-Boot] [PATCH 7/7] spi: remove define for SPI default SPEED and MODE Patrick Delaunay
2018-12-10 11:26   ` Simon Goldschmidt
2018-12-10 21:10     ` Petr Vorel
2018-12-10 15:42 ` [U-Boot] [PATCH 0/7] Remove defines for SPI default speed and mode Adam Ford
2018-12-10 19:20   ` Simon Goldschmidt
2018-12-10 20:17     ` Adam Ford
2018-12-10 21:08       ` Simon Goldschmidt
2018-12-12  7:51         ` Petr Vorel
2018-12-12  9:54           ` Simon Goldschmidt
2018-12-13 14:46             ` Patrick DELAUNAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210122247.7983c568@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox