public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
Date: Mon, 10 Dec 2018 07:23:36 -0500	[thread overview]
Message-ID: <20181210122336.GH8702@bill-the-cat> (raw)
In-Reply-To: <CAP9ODKpgy7N4iuKKobNan+5otJ9T0++yvG0aHphd5j2q5-Nhfw@mail.gmail.com>

On Mon, Dec 10, 2018 at 10:01:06AM -0200, Otavio Salvador wrote:
> On Sun, Dec 9, 2018 at 10:28 PM Tom Rini <trini@konsulko.com> wrote:
> > On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> > > > We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> > > > fdt relocation, so the initramfs works out of box.
> > > >
> > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > > > ---
> > > >
> > > >  include/configs/rv1108_common.h | 4 +++-
> > > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > >
> > > Applied to u-boot-rockchip, thanks!
> >
> > Ugh, sorry for not spotting this sooner.  Please don't disable
> > fdt/initrd relocation and instead use bootm_size.
> 
> I never used it, any reference to look at?

Specifically?  No.  There should be a lot of general hits on
$search-engine over it however as not disabling and instead using
bootm_size is how to fix "Kernel suddenly stops booting... oh we're
overwriting fdt/initrd".

This isn't to say that disabling fdt/initrd relocation isn't a useful
production optimization, it is.  But it's not a good general best
practice.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181210/3213115b/attachment.sig>

      reply	other threads:[~2018-12-10 12:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 13:49 [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs Otavio Salvador
2018-12-06 13:46 ` Philipp Tomsich
2018-12-06 23:00   ` Otavio Salvador
2018-12-06 23:03     ` Philipp Tomsich
2018-12-10  0:01 ` [U-Boot] " Philipp Tomsich
2018-12-10  0:28   ` Tom Rini
2018-12-10  0:38     ` Philipp Tomsich
2018-12-10  0:56       ` Tom Rini
2018-12-10 23:12         ` Philipp Tomsich
2018-12-11  6:25           ` Heiko Stuebner
2018-12-10 12:01     ` Otavio Salvador
2018-12-10 12:23       ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210122336.GH8702@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox