From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 10 Dec 2018 13:10:11 -0500 Subject: [U-Boot] [PATCH v4 12/25] mtd: ensure MTD and NOR drivers are compiled with ENV_IS_IN_FLASH In-Reply-To: <20181210190245.50324d1b@xps13> References: <20181209180747.24575-1-miquel.raynal@bootlin.com> <20181209180747.24575-13-miquel.raynal@bootlin.com> <20181210190245.50324d1b@xps13> Message-ID: <20181210181011.GV8702@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Dec 10, 2018 at 07:02:45PM +0100, Miquel Raynal wrote: > Hello, > > Miquel Raynal wrote on Sun, 9 Dec 2018 > 19:07:34 +0100: > > > MTD and NOR flash support must be enabled when the environment is in > > NOR. > > > > Signed-off-by: Miquel Raynal > > --- > > configs/armadillo-800eva_defconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/configs/armadillo-800eva_defconfig b/configs/armadillo-800eva_defconfig > > index b1d923c069..72758884b4 100644 > > --- a/configs/armadillo-800eva_defconfig > > +++ b/configs/armadillo-800eva_defconfig > > @@ -32,6 +32,8 @@ CONFIG_CMD_PING=y > > # CONFIG_CMD_MISC is not set > > CONFIG_ENV_IS_IN_FLASH=y > > # CONFIG_MMC is not set > > +CONFIG_MTD=y > > +CONFIG_MTD_NOR_FLASH=y > > CONFIG_SH_ETHER=y > > CONFIG_SCIF_CONSOLE=y > > CONFIG_OF_LIBFDT=y > > This change triggered a build failure. This is because, despite > declaring an in-flash environment, there was absolutely no MTD driver > compiled-in. No driver named after 'flash' or 'nor' or 'mtd' was > compiled. > > The fix for this issue (the only one reported by Travis for this > version of the series) is to just drop this patch. As it has absolutely > no dependency and only impacts a single defconfig, I would rather > prefer not re-send 24 identical patches in a v5 unless there are > comments that I must address. Thanks. Do you have a patchwork account? If so you should be able to manage the status of your own at least and marking it as "Rejected" or "Not Applicable" or anything like that will mean it won't be picked up by accident. If not, I'll get to it soon. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: