From mboxrd@z Thu Jan  1 00:00:00 1970
From: Petr Vorel <petr.vorel@gmail.com>
Date: Mon, 10 Dec 2018 22:10:28 +0100
Subject: [U-Boot] [PATCH 7/7] spi: remove define for SPI default SPEED
 and MODE
In-Reply-To: <CAAh8qszi0azt0tPQqnB_jMex6mwhRSj-aeAEp1GDVfkTVr8iCw@mail.gmail.com>
References: <1544439166-5749-1-git-send-email-patrick.delaunay@st.com>
 <1544439166-5749-8-git-send-email-patrick.delaunay@st.com>
 <CAAh8qszi0azt0tPQqnB_jMex6mwhRSj-aeAEp1GDVfkTVr8iCw@mail.gmail.com>
Message-ID: <20181210211026.GF6010@x230>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Patrick,

> On Mon, Dec 10, 2018 at 11:53 AM Patrick Delaunay
> <patrick.delaunay@st.com> wrote:

> > In DM mode, the speed and mode defaults value will be taken from DT,
> > so these defines should be never used and can be removed.

> > Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Reviewed-by: Petr Vorel <petr.vorel@gmail.com>
> > ---

> >  include/spi_flash.h | 4 ++++
> >  1 file changed, 4 insertions(+)

> > diff --git a/include/spi_flash.h b/include/spi_flash.h
> > index 36565bb..c9d20a5 100644
> > --- a/include/spi_flash.h
> > +++ b/include/spi_flash.h
> > @@ -12,12 +12,16 @@
> >  #include <dm.h>        /* Because we dereference struct udevice here */
> >  #include <linux/types.h>

> > +#ifndef CONFIG_DM_SPI_FLASH
> > +/* In DM mode, speed and mode value will be taken from DT */
> >  #ifndef CONFIG_SF_DEFAULT_SPEED
> >  # define CONFIG_SF_DEFAULT_SPEED       1000000
> >  #endif
> >  #ifndef CONFIG_SF_DEFAULT_MODE
> >  # define CONFIG_SF_DEFAULT_MODE                SPI_MODE_3
> >  #endif
> > +#endif
Also: maybe indent preprocessor code?


Kind regards,
Petr