From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Tue, 11 Dec 2018 08:49:56 +0100 Subject: [U-Boot] [PATCH v4 12/25] mtd: ensure MTD and NOR drivers are compiled with ENV_IS_IN_FLASH In-Reply-To: <20181210181011.GV8702@bill-the-cat> References: <20181209180747.24575-1-miquel.raynal@bootlin.com> <20181209180747.24575-13-miquel.raynal@bootlin.com> <20181210190245.50324d1b@xps13> <20181210181011.GV8702@bill-the-cat> Message-ID: <20181211084956.23000c5b@xps13> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de Hi Tom, Tom Rini wrote on Mon, 10 Dec 2018 13:10:11 -0500: > On Mon, Dec 10, 2018 at 07:02:45PM +0100, Miquel Raynal wrote: > > Hello, > >=20 > > Miquel Raynal wrote on Sun, 9 Dec 2018 > > 19:07:34 +0100: > > =20 > > > MTD and NOR flash support must be enabled when the environment is in > > > NOR. > > >=20 > > > Signed-off-by: Miquel Raynal > > > --- > > > configs/armadillo-800eva_defconfig | 2 ++ > > > 1 file changed, 2 insertions(+) > > >=20 > > > diff --git a/configs/armadillo-800eva_defconfig b/configs/armadillo-8= 00eva_defconfig > > > index b1d923c069..72758884b4 100644 > > > --- a/configs/armadillo-800eva_defconfig > > > +++ b/configs/armadillo-800eva_defconfig > > > @@ -32,6 +32,8 @@ CONFIG_CMD_PING=3Dy > > > # CONFIG_CMD_MISC is not set > > > CONFIG_ENV_IS_IN_FLASH=3Dy > > > # CONFIG_MMC is not set > > > +CONFIG_MTD=3Dy > > > +CONFIG_MTD_NOR_FLASH=3Dy > > > CONFIG_SH_ETHER=3Dy > > > CONFIG_SCIF_CONSOLE=3Dy > > > CONFIG_OF_LIBFDT=3Dy =20 > >=20 > > This change triggered a build failure. This is because, despite > > declaring an in-flash environment, there was absolutely no MTD driver > > compiled-in. No driver named after 'flash' or 'nor' or 'mtd' was > > compiled. > >=20 > > The fix for this issue (the only one reported by Travis for this > > version of the series) is to just drop this patch. As it has absolutely > > no dependency and only impacts a single defconfig, I would rather > > prefer not re-send 24 identical patches in a v5 unless there are > > comments that I must address. =20 >=20 > Thanks. Do you have a patchwork account? If so you should be able to > manage the status of your own at least and marking it as "Rejected" or > "Not Applicable" or anything like that will mean it won't be picked up > by accident. If not, I'll get to it soon. >=20 I do have an account on ozlabs' patchwork. I went there to discard this patch but I saw that someone (probably you) already did it. Thanks, Miqu=C3=A8l