* [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig
@ 2018-12-11 17:12 Andy Shevchenko
2018-12-11 17:12 ` [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND " Andy Shevchenko
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Andy Shevchenko @ 2018-12-11 17:12 UTC (permalink / raw)
To: u-boot
Use defconfig instead of header file for CONFIG_CMD_PCI.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
configs/edison_defconfig | 1 -
include/configs/edison.h | 3 ---
2 files changed, 4 deletions(-)
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index b523fe92ce..e376c0cea6 100644
--- a/configs/edison_defconfig
+++ b/configs/edison_defconfig
@@ -19,7 +19,6 @@ CONFIG_CMD_DFU=y
CONFIG_CMD_GPT=y
CONFIG_CMD_MMC=y
CONFIG_CMD_PART=y
-# CONFIG_CMD_PCI is not set
# CONFIG_CMD_NFS is not set
CONFIG_CMD_TIMER=y
CONFIG_CMD_HASH=y
diff --git a/include/configs/edison.h b/include/configs/edison.h
index 86c584d73d..8e312da2da 100644
--- a/include/configs/edison.h
+++ b/include/configs/edison.h
@@ -43,9 +43,6 @@
#define CONFIG_ENV_OFFSET_REDUND (6 * 1024 * 1024)
#define CONFIG_SUPPORT_EMMC_BOOT
-/* PCI */
-#define CONFIG_CMD_PCI
-
/* RTC */
#define CONFIG_SYS_ISA_IO_BASE_ADDRESS 0
--
2.19.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND from header file to defconfig
2018-12-11 17:12 [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig Andy Shevchenko
@ 2018-12-11 17:12 ` Andy Shevchenko
2018-12-31 0:40 ` Bin Meng
2018-12-11 17:12 ` [U-Boot] [PATCH v1 3/3] x86: edison: Remove staled comments from configuration header Andy Shevchenko
2018-12-31 0:40 ` [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig Bin Meng
2 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2018-12-11 17:12 UTC (permalink / raw)
To: u-boot
Use defconfig instead of header file for CONFIG_BOOTCOMMAND.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/configs/edison.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/configs/edison.h b/include/configs/edison.h
index 8e312da2da..7e2f9c129e 100644
--- a/include/configs/edison.h
+++ b/include/configs/edison.h
@@ -10,9 +10,6 @@
/* ACPI */
-/* Boot */
-#define CONFIG_BOOTCOMMAND "run bootcmd"
-
/* DISK Partition support */
/* Miscellaneous configurable options */
--
2.19.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND from header file to defconfig
2018-12-11 17:12 ` [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND " Andy Shevchenko
@ 2018-12-31 0:40 ` Bin Meng
2018-12-31 1:44 ` Bin Meng
0 siblings, 1 reply; 9+ messages in thread
From: Bin Meng @ 2018-12-31 0:40 UTC (permalink / raw)
To: u-boot
On Wed, Dec 12, 2018 at 1:12 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Use defconfig instead of header file for CONFIG_BOOTCOMMAND.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/configs/edison.h | 3 ---
> 1 file changed, 3 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND from header file to defconfig
2018-12-31 0:40 ` Bin Meng
@ 2018-12-31 1:44 ` Bin Meng
0 siblings, 0 replies; 9+ messages in thread
From: Bin Meng @ 2018-12-31 1:44 UTC (permalink / raw)
To: u-boot
On Mon, Dec 31, 2018 at 8:40 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Wed, Dec 12, 2018 at 1:12 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Use defconfig instead of header file for CONFIG_BOOTCOMMAND.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > include/configs/edison.h | 3 ---
> > 1 file changed, 3 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v1 3/3] x86: edison: Remove staled comments from configuration header
2018-12-11 17:12 [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig Andy Shevchenko
2018-12-11 17:12 ` [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND " Andy Shevchenko
@ 2018-12-11 17:12 ` Andy Shevchenko
2018-12-31 0:40 ` Bin Meng
2018-12-31 0:40 ` [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig Bin Meng
2 siblings, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2018-12-11 17:12 UTC (permalink / raw)
To: u-boot
Since some options had been moved to defconfig from header,
the leftover comments are not needed anymore. Remove them.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
include/configs/edison.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/configs/edison.h b/include/configs/edison.h
index 7e2f9c129e..a6155ba5a8 100644
--- a/include/configs/edison.h
+++ b/include/configs/edison.h
@@ -8,10 +8,6 @@
#include <asm/ibmpc.h>
-/* ACPI */
-
-/* DISK Partition support */
-
/* Miscellaneous configurable options */
#define CONFIG_SYS_CBSIZE 2048
--
2.19.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v1 3/3] x86: edison: Remove staled comments from configuration header
2018-12-11 17:12 ` [U-Boot] [PATCH v1 3/3] x86: edison: Remove staled comments from configuration header Andy Shevchenko
@ 2018-12-31 0:40 ` Bin Meng
2018-12-31 1:44 ` Bin Meng
0 siblings, 1 reply; 9+ messages in thread
From: Bin Meng @ 2018-12-31 0:40 UTC (permalink / raw)
To: u-boot
On Wed, Dec 12, 2018 at 1:12 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Since some options had been moved to defconfig from header,
> the leftover comments are not needed anymore. Remove them.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/configs/edison.h | 4 ----
> 1 file changed, 4 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v1 3/3] x86: edison: Remove staled comments from configuration header
2018-12-31 0:40 ` Bin Meng
@ 2018-12-31 1:44 ` Bin Meng
0 siblings, 0 replies; 9+ messages in thread
From: Bin Meng @ 2018-12-31 1:44 UTC (permalink / raw)
To: u-boot
On Mon, Dec 31, 2018 at 8:40 AM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> On Wed, Dec 12, 2018 at 1:12 AM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > Since some options had been moved to defconfig from header,
> > the leftover comments are not needed anymore. Remove them.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > include/configs/edison.h | 4 ----
> > 1 file changed, 4 deletions(-)
> >
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
applied to u-boot-x86, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig
2018-12-11 17:12 [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig Andy Shevchenko
2018-12-11 17:12 ` [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND " Andy Shevchenko
2018-12-11 17:12 ` [U-Boot] [PATCH v1 3/3] x86: edison: Remove staled comments from configuration header Andy Shevchenko
@ 2018-12-31 0:40 ` Bin Meng
2018-12-31 1:43 ` Bin Meng
2 siblings, 1 reply; 9+ messages in thread
From: Bin Meng @ 2018-12-31 0:40 UTC (permalink / raw)
To: u-boot
On Wed, Dec 12, 2018 at 1:12 AM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Use defconfig instead of header file for CONFIG_CMD_PCI.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> configs/edison_defconfig | 1 -
> include/configs/edison.h | 3 ---
> 2 files changed, 4 deletions(-)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-12-31 1:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-11 17:12 [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig Andy Shevchenko
2018-12-11 17:12 ` [U-Boot] [PATCH v1 2/3] x86: edison: move CONFIG_BOOTCOMMAND " Andy Shevchenko
2018-12-31 0:40 ` Bin Meng
2018-12-31 1:44 ` Bin Meng
2018-12-11 17:12 ` [U-Boot] [PATCH v1 3/3] x86: edison: Remove staled comments from configuration header Andy Shevchenko
2018-12-31 0:40 ` Bin Meng
2018-12-31 1:44 ` Bin Meng
2018-12-31 0:40 ` [U-Boot] [PATCH v1 1/3] x86: edison: move CONFIG_CMD_PCI from header file to defconfig Bin Meng
2018-12-31 1:43 ` Bin Meng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox