From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Wed, 12 Dec 2018 18:36:10 +0100 Subject: [U-Boot] [PATCH 2/2] mtd: Get rid of board_mtdparts_default() In-Reply-To: <20181212113704.GA23132@lenoch> References: <20181210153850.3272-1-boris.brezillon@bootlin.com> <20181210153850.3272-2-boris.brezillon@bootlin.com> <20181211213409.GA11948@lenoch> <20181212103251.1a44b57c@bbrezillon> <20181212113704.GA23132@lenoch> Message-ID: <20181212183610.5d072e33@bbrezillon> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 12 Dec 2018 12:37:04 +0100 Ladislav Michl wrote: > Now problem is that IGEPv2 comes with quite many configurations, some of > them are even customized, so static configuration is a show stopper > mainly as I do not know what devices are in field. > Another issue is how ubispl code works: It expects struct ubispl_info > filled with (among others) peb_offset of ubi partition. ubispl code counts > in terms of eraseblocks regardless of their size. So we would need to touch > this number when using static mtdparts. Okay. > > > > Hence runtime detection. That code could be used > > > on all OMAP3 boards as BootROM reads up to first four sectors searching > > > for SPL (MLO). > > > > Note that, for the nand side of things, you can also automate that using > > a u-boot script: > > > > nand info; setexpr splsize ${nand_erasesize} * 4; setenv mtdparts mtdparts=omap2-nand:0x${splsize}(SPL),-(UBI) > > That seems as a way to go! Glad you like this idea. > > > Shouldn't be hard to patch the onenand cmd to also expose writesize, > > erasesize and oobsize. > > Side note: I never fully understand why is OneNAND using separate set of > commands. Hehe. That's exactly what Miquel tries to address with the mtd command (one command to rule them all). > > Could you hold merging your paches until I implement above idea and test > it on a few boards? I know u-boot is now using two months merge window, > which is unfortunate, so I'll try to do it as soon as possible, but I do > not think I'll finish it till end of week. No worries. This is not urgent and can definitely wait 2019.04. Thanks, Boris