From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Date: Wed, 12 Dec 2018 21:51:39 +0100 Subject: [U-Boot] [PATCH 10/16] configs: Get rid of SPI_FLASH_BAR In-Reply-To: References: <20181212173228.12281-1-vigneshr@ti.com> <20181212173228.12281-11-vigneshr@ti.com> Message-ID: <20181212215139.19547b86@bbrezillon> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 13 Dec 2018 02:11:48 +0530 Jagan Teki wrote: > On Wed, Dec 12, 2018 at 11:15 PM Vignesh R wrote: > > > > Now that we have new SPI NOR framework in place that supports 4 byte > > addressing mode by default, get rid of CONFIG_SPI_FLASH_BAR > > I already mentioned in previous mail, BAR is not exact replacement for > 4-byte. Some controllers do handle > 16MB flashes even-though > controller support 3-byte addressing. we have these board since from > 2014. That's something you should be able to detect with spi_mem_supports_op(). If the controller does not support sending 4 byte addresses, it should return -ENOTSUPP and the framework should fallback to BAR setting (if the NOR supports it). Do we really need a config option for that?