[U-Boot] [PATCH v2 04/11] exynos: Convert to use CONFIG_BLK

Lukasz Majewski
2018-12-17T07:48:48Z

On Sun, 16 Dec 2018 19:36:31 -0700
Simon Glass <sjg@chromium.org> wrote:

> Move all exynos boards over to use CONFIG_BLK.
>
> This converts s5p_goni also, but adding dummy functions for pinmux and
> peripheral ID. This will not function correctly, but gives the
> maintainer more time to convert the board if desired.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Update to convert s5p_goni also
>
> arch/arm/mach-exynos/Kconfig | 7 +++++++
> arch/arm/mach-s5pc1xx/Kconfig | 2 ++
> arch/arm/mach-s5pc1xx/Makefile | 1 +
> arch/arm/mach-s5pc1xx/pinmux.c | 20 ++++++++++++++++++++
> 4 files changed, 30 insertions(+)
> create mode 100644 arch/arm/mach-s5pc1xx/pinmux.c
>
> diff --git a/arch/arm/mach-exynos/Kconfig
> b/arch/arm/mach-exynos/Kconfig index ed04369cfae..38077703621 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -8,6 +8,8 @@ config ARCH_EXYNOS4
> bool "Exynos4 SoC family"
> select BOARD_EARLY_INIT_F
> select CPU_V7A
> + select BLK
> + select DM_MMC
> help
> Samsung Exynos4 SoC family are based on ARM Cortex-A9 CPU.
> There are multiple SoCs in this family including Exynos4210,
> Exynos4412, @@ -24,6 +26,9 @@ config ARCH_EXYNOS5
> imply USB_ETHER_ASIX
> imply USB_ETHER_RTL8152
> imply USB_ETHER_SMSC95XX
> + select BLK
> + select DM_MMC
> +
> help
> Samsung Exynos5 SoC family are based on ARM Cortex-A15 CPU
> (and Cortex-A7 CPU in big.LITTLE configuration). There are multiple
> SoCs @@ -33,6 +38,8 @@ config ARCH_EXYNOS7
> bool "Exynos7 SoC family"
> select ARM64
> select BOARD_EARLY_INIT_F
> + select BLK
> + select DM_MMC
> help
> Samsung Exynos7 SoC family are based on ARM Cortex-A57 CPU
> or Cortex-A53 CPU (and some in a big.LITTLE configuration). There are
> diff --git a/arch/arm/mach-s5pc1xx/Kconfig
> b/arch/arm/mach-s5pc1xx/Kconfig index 04acdaad79c..8cffced5512 100644
> --- a/arch/arm/mach-s5pc1xx/Kconfig
> +++ b/arch/arm/mach-s5pc1xx/Kconfig
> @@ -7,6 +7,8 @@ choice
> config TARGET_S5P_GONI
> bool "S5P Goni board"
> select OF_CONTROL
> + select BLK
> + select DM_MMC
>
> config TARGET_SMDKC100
> bool "Support smdkc100 board"
> diff --git a/arch/arm/mach-s5pc1xx/Makefile
> b/arch/arm/mach-s5pc1xx/Makefile index a4be3fcbdae..ab804604d54 100644
> --- a/arch/arm/mach-s5pc1xx/Makefile
> +++ b/arch/arm/mach-s5pc1xx/Makefile
> @@ -10,3 +10,4 @@ obj-y = cache.o
> obj-y += reset.o
>
> obj-y += clock.o
> +obj-y += pinmux.o
> diff --git a/arch/arm/mach-s5pc1xx/pinmux.c
> b/arch/arm/mach-s5pc1xx/pinmux.c new file mode 100644
> index 00000000000..511e57a28df
> --- /dev/null
> +++ b/arch/arm/mach-s5pc1xx/pinmux.c
> @@ -0,0 +1,20 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Dummy functions to keep s3p_goni building (although it won't work)
^^^^ s5p_goni

> + *
> + * Copyright 2018 Google LLC
> + * Written by Simon Glass <sjg@chromium.org>
> + */
> +
> +#include <common.h>
> +#include <asm/arch/pinmux.h>
> +
> +int exynos_pinmux_config(int peripheral, int flags)
> +{
> + return 0;
> +}
> +
> +int pinmux_decode_periph_id(const void *blob, int node)
> +{
> + return 0;
> +}

Despite the above comment, rest seems Ok.

Reviewed-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181217/96455b7f/attachment.sig>