public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anup Patel <anup@brainfault.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] net: macb: Fix clk API usage for RISC-V systems
Date: Mon, 17 Dec 2018 17:21:42 +0530	[thread overview]
Message-ID: <20181217115143.18373-3-anup@brainfault.org> (raw)
In-Reply-To: <20181217115143.18373-1-anup@brainfault.org>

From: Anup Patel <anup.patel@wdc.com>

This patch does following fixes in MACB ethernet driver
for using it on RISC-V systems (particularly QEMU sifive_u
machine):
1. asm/arch/clk.h is not available on RISC-V port so include
   it only for non-RISC-V systems.
2. Don't fail in macb_enable_clk() if clk_enable() returns
   -ENOSYS because we get -ENOSYS for fixed-rate clocks.

Signed-off-by: Anup Patel <anup.patel@wdc.com>
---
 drivers/net/macb.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 94c89c762b..9a06b523cc 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -38,7 +38,9 @@
 #include <linux/mii.h>
 #include <asm/io.h>
 #include <asm/dma-mapping.h>
+#ifndef CONFIG_RISCV
 #include <asm/arch/clk.h>
+#endif
 #include <linux/errno.h>
 
 #include "macb.h"
@@ -1066,7 +1068,7 @@ static int macb_enable_clk(struct udevice *dev)
 	 */
 #ifndef CONFIG_MACB_ZYNQ
 	ret = clk_enable(&clk);
-	if (ret)
+	if (ret && ret != -ENOSYS)
 		return ret;
 #endif
 
-- 
2.17.1

  parent reply	other threads:[~2018-12-17 11:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 11:51 [U-Boot] [PATCH 0/3] Ethernet support for QEMU sifive_u machine Anup Patel
2018-12-17 11:51 ` [U-Boot] [PATCH 1/3] riscv: Add asm/dma-mapping.h for DMA mappings Anup Patel
2018-12-18  9:45   ` Bin Meng
2018-12-19  8:09     ` Anup Patel
2018-12-20  5:26   ` Anup Patel
2018-12-17 11:51 ` Anup Patel [this message]
2018-12-18  9:45   ` [U-Boot] [PATCH 2/3] net: macb: Fix clk API usage for RISC-V systems Bin Meng
2018-12-19  8:15     ` Anup Patel
2018-12-17 11:51 ` [U-Boot] [PATCH 3/3] riscv: qemu: Imply MACB ethernet for emulation Anup Patel
2018-12-18  9:45   ` Bin Meng
2018-12-18  9:51 ` [U-Boot] [PATCH 0/3] Ethernet support for QEMU sifive_u machine Bin Meng
2018-12-18 10:33   ` Anup Patel
2018-12-18 10:36     ` Bin Meng
2018-12-19  4:40       ` Anup Patel
2018-12-19  5:32         ` Bin Meng
2018-12-19  6:32           ` Anup Patel
2018-12-19  9:05             ` Bin Meng
2018-12-24  1:29               ` Bin Meng
2018-12-24  5:41                 ` Anup Patel
2018-12-24  6:31                   ` Bin Meng
2018-12-24  6:42                     ` Anup Patel
2018-12-24  7:15                       ` Bin Meng
2018-12-24  7:23                         ` Anup Patel
2018-12-24  7:36                           ` Bin Meng
2018-12-24 11:34                             ` Anup Patel
2019-08-07 15:37               ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217115143.18373-3-anup@brainfault.org \
    --to=anup@brainfault.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox