From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Mon, 17 Dec 2018 07:11:04 -0500 Subject: [U-Boot] poplar: fix boot failure caused by serial driver change In-Reply-To: <20181212072444.11137-1-shawn.guo@linaro.org> References: <20181212072444.11137-1-shawn.guo@linaro.org> Message-ID: <20181217121104.GI8702@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Dec 12, 2018 at 03:24:44PM +0800, Shawn Guo wrote: > Commit 4687919684e0 ("serial: Remove DM_FLAG_PRE_RELOC flag in various > drivers") essentially drops flag DM_FLAG_PRE_RELOC from serial_pl01x > driver for Poplar platform, because the platform falls into the > following strategy category made by the commit. > > Surround DM_FLAG_PRE_RELOC flag with OF_CONTROL check, for > drivers that support both statically declared devices and > configuration from device tree > > Before the commit lands, Poplar platform works by statically declaring > pl011 serial device via U_BOOT_DEVICE() with DM_FLAG_PRE_RELOC flag set > in the driver. But since Poplar also supports device configuration from > device tree, the commit practically drops the flag for Poplar, and hence > breaks the platform from booting. > > This patch changes platform code and device tree to initiate pl011 > serial device from device tree rather than static declaration, so that > above strategy about DM_FLAG_PRE_RELOC applies to Poplar, and therefore > the reported boot failure gets fixed. > > Reported-by: Igor Opaniuk > Fixes: 4687919684e0 ("serial: Remove DM_FLAG_PRE_RELOC flag in various drivers") > Cc: Bin Meng > Cc: Simon Glass > Signed-off-by: Shawn Guo > Reviewed-by: Igor Opaniuk > Tested-by: Igor Opaniuk > Reviewed-by: Bin Meng Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: