From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 02/14] tpc70: config: Update TPC70 config to support eMMC's boot0 SPL update
Date: Wed, 2 Jan 2019 10:47:49 +0100 [thread overview]
Message-ID: <20190102104749.017e2579@jawa> (raw)
In-Reply-To: <af6c42e2-c0cd-7db4-51ba-b1f5199e075b@denx.de>
Hi Marek,
> On 1/2/19 12:37 AM, Lukasz Majewski wrote:
> > The TPC70 can boot from eMMC's boot0. This patch allows it to update
> > this HW partition's SPL.
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > ---
> >
> > include/configs/kp_imx6q_tpc.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/include/configs/kp_imx6q_tpc.h
> > b/include/configs/kp_imx6q_tpc.h index ee9c56bc21..f26b18442b 100644
> > --- a/include/configs/kp_imx6q_tpc.h
> > +++ b/include/configs/kp_imx6q_tpc.h
> > @@ -49,6 +49,7 @@
> > #define CONFIG_SYS_FSL_ESDHC_ADDR 0
> > #define CONFIG_SYS_FSL_USDHC_NUM 2
> > #define CONFIG_SYS_MMC_ENV_DEV 1 /* 0 = SDHC2, 1 =
> > SDHC4 (eMMC) */ +#define CONFIG_SUPPORT_EMMC_BOOT
> >
> > /* UART */
> > #define CONFIG_MXC_UART
> > @@ -109,6 +110,10 @@
> > "setexpr blkc ${blkc} + 1;" \
> > "mmc write ${loadaddr} 0x2 ${blkc};" \
> > "fi;\0" \
> > + "upd_SPL_mmc=mmc dev 1; mmc partconf 1 0 1 1; run
> > upd_SPL_sd\0" \
>
> If mmc dev 1 fails, this will randomly rewrite or even damage some
> SD/MMC card that was selected before
>. Use && ...
Ok - good point.
>
> > + "upd_uboot_mmc=mmc dev 1; mmc partconf 1 0 1 1; run
> > upd_uboot_sd\0" \
>
> Deduplicate these repeated commands.
Could you be more specific here?
Without mmc dev 1 and partconf I cannot access boot0 eMMC area.
This particular board has the SD as mmc0 (rescue/devel) and eMMC as
mmc1 (and eMMC is a production boot medium).
>
> > + "up_mmc=run upd_SPL_mmc; run upd_uboot_mmc\0" \
> > + "up_sd=run upd_SPL_sd; run upd_uboot_sd\0" \
> > "upd_wic=" \
> > "if tftp ${loadaddr} ${wic_file}; then " \
> > "setexpr blkc ${filesize} / 0x200;" \
> >
>
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190102/24532dd1/attachment.sig>
next prev parent reply other threads:[~2019-01-02 9:47 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-01 23:37 [U-Boot] [PATCH v1 00/14] dm: Convert TPC70 to use DM and DTS in SPL and u-boot proper Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 01/14] tpc70: config: Add script commands to update u-boot and OE's wic Lukasz Majewski
2019-01-02 1:07 ` Marek Vasut
2019-01-02 9:50 ` Lukasz Majewski
2019-01-02 14:09 ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 02/14] tpc70: config: Update TPC70 config to support eMMC's boot0 SPL update Lukasz Majewski
2019-01-02 1:08 ` Marek Vasut
2019-01-02 9:47 ` Lukasz Majewski [this message]
2019-01-02 14:09 ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 03/14] tpc70: Provide board_boot_order() function to distinct between eMMC and SD boot Lukasz Majewski
2019-01-05 1:57 ` Simon Glass
2019-01-01 23:37 ` [U-Boot] [PATCH v1 04/14] DTS: imx: Remove not needed '#address-cells' and '#size-cells' properties Lukasz Majewski
2019-01-02 1:09 ` Marek Vasut
2019-01-02 9:43 ` Lukasz Majewski
2019-01-02 14:10 ` Marek Vasut
2019-01-02 14:34 ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 05/14] board: cosmetic: Use define to set ENET clock selection mask on TPC70 Lukasz Majewski
2019-01-02 1:09 ` Marek Vasut
2019-01-02 10:06 ` Lukasz Majewski
2019-01-02 14:12 ` Marek Vasut
2019-01-02 14:37 ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 06/14] DM: tpc70: led: Enable LED default state Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 07/14] pinctrl: imx: Replace static soc info definitions with run time allocations Lukasz Majewski
2019-01-02 1:13 ` Marek Vasut
2019-01-02 8:26 ` Lukasz Majewski
2019-01-02 14:14 ` Marek Vasut
2019-01-03 7:22 ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 08/14] DTS: imx: Add "u-boot, dm-pre-reloc" property to relevant imx6qdl nodes Lukasz Majewski
2019-01-02 1:13 ` Marek Vasut
2019-01-02 9:23 ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 09/14] imx: serial: dm: Enable DM_FLAG_PRE_RELOC in the IMX uart driver Lukasz Majewski
2019-01-02 1:14 ` Marek Vasut
2019-01-02 8:42 ` Lukasz Majewski
2019-01-02 14:15 ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 10/14] imx: clock: Introduce set_fec_clock() to configure ETH clock (imx6) Lukasz Majewski
2019-01-02 1:16 ` Marek Vasut
2019-01-02 9:00 ` Lukasz Majewski
2019-01-02 14:18 ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 11/14] DM: net: imx: Provide weak function to initialize fec clocks Lukasz Majewski
2019-01-02 1:17 ` Marek Vasut
2019-01-02 8:47 ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 12/14] imx: mmc: Use 'fsl, usdhc-index' property to provide esdhc controller number Lukasz Majewski
2019-01-02 1:18 ` Marek Vasut
2019-01-02 10:31 ` Lukasz Majewski
2019-01-02 14:17 ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 13/14] DTS: imx: tpc70: Add TPC70 board (imx6q based) device tree description Lukasz Majewski
2019-01-02 1:19 ` Marek Vasut
2019-01-02 8:49 ` Lukasz Majewski
2019-01-02 14:17 ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 14/14] imx: tpc70: Convert TPC70 (imx6q based) board to use DM/DTS in SPL and u-boot Lukasz Majewski
2019-01-05 1:57 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190102104749.017e2579@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox