From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 2 Jan 2019 13:15:06 +0100 Subject: [U-Boot] [PATCH] dm: usb: gadget: Fix boot breakage on sunxi platforms In-Reply-To: <1334d28c-5b96-1359-811c-e1491c8aba7d@ti.com> References: <1545382221-21788-1-git-send-email-jjhiblot@ti.com> <1334d28c-5b96-1359-811c-e1491c8aba7d@ti.com> Message-ID: <20190102131506.03a70616@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: u-boot@lists.denx.de On Wed, 2 Jan 2019 11:38:47 +0100 Jean-Jacques Hiblot wrote: > On 29/12/2018 19:49, Jagan Teki wrote: > > On Mon, Dec 24, 2018 at 3:44 AM Jagan Teki > > wrote: =20 > >> On Fri, Dec 21, 2018 at 2:20 PM Jean-Jacques Hiblot > >> wrote: Better to have proper commit head that > >> tells the real issue. =20 >=20 > I found it hard to come up with a short description of the real issue. >=20 > At least this title makes it clear that it is a regression fix, not a=20 > new feature. >=20 > The details of the failures=C2=A0 are in the commit log (or so I thought) >=20 > >> =20 > >>> Fixes commit 013116243950 ("dm: usb: create a new UCLASS ID for > >>> USB gadget devices") > >>> > >>> The UCLASS_DRIVER for id UCLASS_USB_GADGET_GENERIC needs to be > >>> declared even for platforms that do not enable DM_USB_GADGET. > >>> Otherwise the driver for their usb peripheral controller fails to > >>> bind. =20 > >> Sorry this is unclear, you are trying to skip DM_USB_GADGET code > >> even though UCLASS_USB_GADGET_GENERIC id used. does it make > >> sense? =20 >=20 > Sorry for the delay. This was indeed a vacation time. >=20 > This patch does not skip DM_USB_GADGET. What it does is declare the=20 > UCLASS_DRIVER for USB peripheral devices even if DM_USB_GADGET is not > set. >=20 > DM_USB_GADGET is a new option and not (yet) widely used and some > drivers have their own version of the DM support for gadget drivers > (ie they implement their own version of usb_gadget_initialize(),=20 > usb_gadget_release() and usb_gadget_handle_interrupts()). However all=20 > those drivers use the UCLASS_USB_GADGET_GENERIC uclass ID and thus > the UCLASS_DRIVER for UCLASS_USB_GADGET_GENERIC must be declared. In > the past they used UCLASS_USB_DEV_GENERIC, but this option is > intended for the host side. >=20 Thanks for a detailed explanation. Would you prepare v2 soon? >=20 > JJ >=20 > > Any response on this? > > > > We need the fix asap since the release is about a week. > > =20 Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: