public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 04/14] DTS: imx: Remove not needed '#address-cells' and '#size-cells' properties
Date: Wed, 2 Jan 2019 15:34:50 +0100	[thread overview]
Message-ID: <20190102153450.07f12de3@jawa> (raw)
In-Reply-To: <cbb54cc6-2a18-608a-b10a-1924b855f424@denx.de>

Hi Marek,

> On 1/2/19 10:43 AM, Lukasz Majewski wrote:
> > Hi Marek,
> >   
> >> On 1/2/19 12:37 AM, Lukasz Majewski wrote:  
> >>> This commit fixes warnings produced by newest in u-boot DTC
> >>> compiler: 'unnecessary #address-cells/#size-cells without "ranges"
> >>> or child "reg" property'
> >>>
> >>> Signed-off-by: Lukasz Majewski <lukma@denx.de>    
> >>
> >> I presume the DTSIs are taken from Linux, is this a backport from
> >> Linux then ?  
> > 
> > Regarding Linux - with Version: DTC 1.4.7-gc86da84d and make W=1 I
> > do not see those warnings as in  scripts/Makefile.lib :
> > 
> > # Disable noisy checks by default
> > ifeq ($(findstring 1,$(KBUILD_ENABLE_EXTRA_GCC_CHECKS)),)
> > DTC_FLAGS += -Wno-unit_address_vs_reg \
> >         -Wno-unit_address_format \
> >         -Wno-avoid_unnecessary_addr_size \
> > 
> > those warnings are disabled (-Wno-avoid_unnecessary_addr_size).
> > 
> > On the other hand - in u-boot those warnings are checked (maybe are
> > necessary for OF_PLATDATA correct operation?).  
> 
> No, keep the DTs synced and fix things upstream (in Linux) if needed,
> then backport the fixes.

Please correct my understanding if I get this wrong.

Do you recommend to send this patch to Linux upstream to fix warnings,
which are disabled (no checked and not present) by default in Linux ?

After this patch is accepted in Linux - I shall backport it to u-boot ?

> 


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190102/f9787ce3/attachment.sig>

  reply	other threads:[~2019-01-02 14:34 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-01 23:37 [U-Boot] [PATCH v1 00/14] dm: Convert TPC70 to use DM and DTS in SPL and u-boot proper Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 01/14] tpc70: config: Add script commands to update u-boot and OE's wic Lukasz Majewski
2019-01-02  1:07   ` Marek Vasut
2019-01-02  9:50     ` Lukasz Majewski
2019-01-02 14:09       ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 02/14] tpc70: config: Update TPC70 config to support eMMC's boot0 SPL update Lukasz Majewski
2019-01-02  1:08   ` Marek Vasut
2019-01-02  9:47     ` Lukasz Majewski
2019-01-02 14:09       ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 03/14] tpc70: Provide board_boot_order() function to distinct between eMMC and SD boot Lukasz Majewski
2019-01-05  1:57   ` Simon Glass
2019-01-01 23:37 ` [U-Boot] [PATCH v1 04/14] DTS: imx: Remove not needed '#address-cells' and '#size-cells' properties Lukasz Majewski
2019-01-02  1:09   ` Marek Vasut
2019-01-02  9:43     ` Lukasz Majewski
2019-01-02 14:10       ` Marek Vasut
2019-01-02 14:34         ` Lukasz Majewski [this message]
2019-01-01 23:37 ` [U-Boot] [PATCH v1 05/14] board: cosmetic: Use define to set ENET clock selection mask on TPC70 Lukasz Majewski
2019-01-02  1:09   ` Marek Vasut
2019-01-02 10:06     ` Lukasz Majewski
2019-01-02 14:12       ` Marek Vasut
2019-01-02 14:37         ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 06/14] DM: tpc70: led: Enable LED default state Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 07/14] pinctrl: imx: Replace static soc info definitions with run time allocations Lukasz Majewski
2019-01-02  1:13   ` Marek Vasut
2019-01-02  8:26     ` Lukasz Majewski
2019-01-02 14:14       ` Marek Vasut
2019-01-03  7:22         ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 08/14] DTS: imx: Add "u-boot, dm-pre-reloc" property to relevant imx6qdl nodes Lukasz Majewski
2019-01-02  1:13   ` Marek Vasut
2019-01-02  9:23     ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 09/14] imx: serial: dm: Enable DM_FLAG_PRE_RELOC in the IMX uart driver Lukasz Majewski
2019-01-02  1:14   ` Marek Vasut
2019-01-02  8:42     ` Lukasz Majewski
2019-01-02 14:15       ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 10/14] imx: clock: Introduce set_fec_clock() to configure ETH clock (imx6) Lukasz Majewski
2019-01-02  1:16   ` Marek Vasut
2019-01-02  9:00     ` Lukasz Majewski
2019-01-02 14:18       ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 11/14] DM: net: imx: Provide weak function to initialize fec clocks Lukasz Majewski
2019-01-02  1:17   ` Marek Vasut
2019-01-02  8:47     ` Lukasz Majewski
2019-01-01 23:37 ` [U-Boot] [PATCH v1 12/14] imx: mmc: Use 'fsl, usdhc-index' property to provide esdhc controller number Lukasz Majewski
2019-01-02  1:18   ` Marek Vasut
2019-01-02 10:31     ` Lukasz Majewski
2019-01-02 14:17       ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 13/14] DTS: imx: tpc70: Add TPC70 board (imx6q based) device tree description Lukasz Majewski
2019-01-02  1:19   ` Marek Vasut
2019-01-02  8:49     ` Lukasz Majewski
2019-01-02 14:17       ` Marek Vasut
2019-01-01 23:37 ` [U-Boot] [PATCH v1 14/14] imx: tpc70: Convert TPC70 (imx6q based) board to use DM/DTS in SPL and u-boot Lukasz Majewski
2019-01-05  1:57   ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190102153450.07f12de3@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox