From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Wed, 2 Jan 2019 15:37:23 +0100 Subject: [U-Boot] [PATCH v1 05/14] board: cosmetic: Use define to set ENET clock selection mask on TPC70 In-Reply-To: <5d1e41d1-ddb9-0595-0497-6261c6730d77@denx.de> References: <20190101233745.16433-1-lukma@denx.de> <20190101233745.16433-6-lukma@denx.de> <24b05042-e315-6063-ffa5-613ae27241e6@denx.de> <20190102110636.2bcec90b@jawa> <5d1e41d1-ddb9-0595-0497-6261c6730d77@denx.de> Message-ID: <20190102153723.2c6a6d6a@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, > On 1/2/19 11:06 AM, Lukasz Majewski wrote: > > Hi Marek, > > > >> On 1/2/19 12:37 AM, Lukasz Majewski wrote: > >>> This is a cosmetic change, just to use proper define. > >>> > >>> Signed-off-by: Lukasz Majewski > >> > >> The subject tags are wrong, fix globally. > > > > Is there any doc which describes the allowed/not allowed tags > > (either with Linux or U-boot)? > > I am not aware of one, however you can write one if you feel inclined > to do so. I was just curious if I have overlooked something. > > > From my experience it is a some kind of a convention depending on > > the maintainer (which helps him to spot relevant patches on ML). > > Right, and this is ARM imx board, hence those tags should be > included. > > > In [1] - point 14) there is: > > The canonical patch subject line is: > > "Subject: [PATCH 001/123] subsystem: summary phrase" > > > > and the "subsystem: " is the tag. > > > > In the case of this patch -> I do fix stuff in "board(s)" which is > > "cosmetic". > > > > Or will we only stick to tags/mails from ./doc/git-mailrc ? > > > > [1] - > > https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html > > [...] > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: