[U-Boot] Bogus message about SCSI during build

[U-Boot] Bogus message about SCSI during build

[Andy Shevchenko]

Hi!

Since X86 implies SCSI and Intel Edison board does not use it, I have got a
===================== WARNING ======================
This board does not use CONFIG_DM_SCSI. Please update
the storage controller to use CONFIG_DM_SCSI before the v2019.07 release.
Failure to update by the deadline may result in board removal.
See doc/driver-model/MIGRATION.txt for more info.
====================================================

Is anybody aware of?

-- 
With Best Regards,
Andy Shevchenko

[U-Boot] Bogus message about SCSI during build

[Bin Meng]

Hi Andy,

On Wed, Dec 12, 2018 at 12:21 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> Hi!
>
> Since X86 implies SCSI and Intel Edison board does not use it, I have got a
> ===================== WARNING ======================
> This board does not use CONFIG_DM_SCSI. Please update
> the storage controller to use CONFIG_DM_SCSI before the v2019.07 release.
> Failure to update by the deadline may result in board removal.
> See doc/driver-model/MIGRATION.txt for more info.
> ====================================================
>
> Is anybody aware of?

AFAIK , this warning message is intentional to push board maintainers
to convert their boards over to driver model.

For the edison board, if SCSI is not used. you can turn it off in the
board defconfig file.

Regards,
Bin

Regards,
Bin

[U-Boot] Bogus message about SCSI during build

[Tom Rini]

On Thu, Dec 13, 2018 at 12:52:21PM +0800, Bin Meng wrote:
> Hi Andy,
> 
> On Wed, Dec 12, 2018 at 12:21 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > Hi!
> >
> > Since X86 implies SCSI and Intel Edison board does not use it, I have got a
> > ===================== WARNING ======================
> > This board does not use CONFIG_DM_SCSI. Please update
> > the storage controller to use CONFIG_DM_SCSI before the v2019.07 release.
> > Failure to update by the deadline may result in board removal.
> > See doc/driver-model/MIGRATION.txt for more info.
> > ====================================================
> >
> > Is anybody aware of?
> 
> AFAIK , this warning message is intentional to push board maintainers
> to convert their boards over to driver model.
> 
> For the edison board, if SCSI is not used. you can turn it off in the
> board defconfig file.

Right.  Our warnings now are perhaps a bit too easy to trip over because
there are cases like this where you don't need SCSI (or other things)
but have them on without having DM_xxx and BLK enabled.  In this case
the right thing to do is disable stuff you don't need.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181226/caadee8a/attachment.sig>

[U-Boot] Bogus message about SCSI during build

[Andy Shevchenko]

On Wed, Dec 26, 2018 at 6:38 PM Tom Rini <trini@konsulko.com> wrote:
>
> On Thu, Dec 13, 2018 at 12:52:21PM +0800, Bin Meng wrote:
> > Hi Andy,
> >
> > On Wed, Dec 12, 2018 at 12:21 AM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:
> > >
> > > Hi!
> > >
> > > Since X86 implies SCSI and Intel Edison board does not use it, I have got a
> > > ===================== WARNING ======================
> > > This board does not use CONFIG_DM_SCSI. Please update
> > > the storage controller to use CONFIG_DM_SCSI before the v2019.07 release.
> > > Failure to update by the deadline may result in board removal.
> > > See doc/driver-model/MIGRATION.txt for more info.
> > > ====================================================
> > >
> > > Is anybody aware of?
> >
> > AFAIK , this warning message is intentional to push board maintainers
> > to convert their boards over to driver model.
> >
> > For the edison board, if SCSI is not used. you can turn it off in the
> > board defconfig file.
>
> Right.  Our warnings now are perhaps a bit too easy to trip over because
> there are cases like this where you don't need SCSI (or other things)
> but have them on without having DM_xxx and BLK enabled.  In this case
> the right thing to do is disable stuff you don't need.

What stuff?
The platform does have DM_MMC and BLK as far as I can see, other than
that I have no idea how CONFIG_DM_SCSI becomes set.
Something broken upper, not on this certain board.

>
> --
> Tom



-- 
With Best Regards,
Andy Shevchenko

[U-Boot] Bogus message about SCSI during build

[Andy Shevchenko]

On Mon, Jan 7, 2019 at 8:34 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Dec 26, 2018 at 6:38 PM Tom Rini <trini@konsulko.com> wrote:
> > On Thu, Dec 13, 2018 at 12:52:21PM +0800, Bin Meng wrote:
> > > On Wed, Dec 12, 2018 at 12:21 AM Andy Shevchenko
> > > <andy.shevchenko@gmail.com> wrote:

> > > > Since X86 implies SCSI and Intel Edison board does not use it, I have got a
> > > > ===================== WARNING ======================
> > > > This board does not use CONFIG_DM_SCSI. Please update
> > > > the storage controller to use CONFIG_DM_SCSI before the v2019.07 release.
> > > > Failure to update by the deadline may result in board removal.
> > > > See doc/driver-model/MIGRATION.txt for more info.
> > > > ====================================================
> > > >
> > > > Is anybody aware of?
> > >
> > > AFAIK , this warning message is intentional to push board maintainers
> > > to convert their boards over to driver model.
> > >
> > > For the edison board, if SCSI is not used. you can turn it off in the
> > > board defconfig file.
> >
> > Right.  Our warnings now are perhaps a bit too easy to trip over because
> > there are cases like this where you don't need SCSI (or other things)
> > but have them on without having DM_xxx and BLK enabled.  In this case
> > the right thing to do is disable stuff you don't need.
>
> What stuff?
> The platform does have DM_MMC and BLK as far as I can see, other than
> that I have no idea how CONFIG_DM_SCSI becomes set.
> Something broken upper, not on this certain board.

config X86
...
    imply DM_SCSI
...

This has to be fixed, not my board. Message now is bogus.

-- 
With Best Regards,
Andy Shevchenko

[U-Boot] Bogus message about SCSI during build

[Tom Rini]

On Mon, Jan 07, 2019 at 08:38:35PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 7, 2019 at 8:34 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Dec 26, 2018 at 6:38 PM Tom Rini <trini@konsulko.com> wrote:
> > > On Thu, Dec 13, 2018 at 12:52:21PM +0800, Bin Meng wrote:
> > > > On Wed, Dec 12, 2018 at 12:21 AM Andy Shevchenko
> > > > <andy.shevchenko@gmail.com> wrote:
> 
> > > > > Since X86 implies SCSI and Intel Edison board does not use it, I have got a
> > > > > ===================== WARNING ======================
> > > > > This board does not use CONFIG_DM_SCSI. Please update
> > > > > the storage controller to use CONFIG_DM_SCSI before the v2019.07 release.
> > > > > Failure to update by the deadline may result in board removal.
> > > > > See doc/driver-model/MIGRATION.txt for more info.
> > > > > ====================================================
> > > > >
> > > > > Is anybody aware of?
> > > >
> > > > AFAIK , this warning message is intentional to push board maintainers
> > > > to convert their boards over to driver model.
> > > >
> > > > For the edison board, if SCSI is not used. you can turn it off in the
> > > > board defconfig file.
> > >
> > > Right.  Our warnings now are perhaps a bit too easy to trip over because
> > > there are cases like this where you don't need SCSI (or other things)
> > > but have them on without having DM_xxx and BLK enabled.  In this case
> > > the right thing to do is disable stuff you don't need.
> >
> > What stuff?
> > The platform does have DM_MMC and BLK as far as I can see, other than
> > that I have no idea how CONFIG_DM_SCSI becomes set.
> > Something broken upper, not on this certain board.
> 
> config X86
> ...
>     imply DM_SCSI
> ...
> 
> This has to be fixed, not my board. Message now is bogus.

Ah, I see now, thanks for being patient with me.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190107/1901fb28/attachment.sig>

[U-Boot] Bogus message about SCSI during build

[Bin Meng]

Hi Andy,

On Tue, Jan 8, 2019 at 2:38 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Jan 7, 2019 at 8:34 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Wed, Dec 26, 2018 at 6:38 PM Tom Rini <trini@konsulko.com> wrote:
> > > On Thu, Dec 13, 2018 at 12:52:21PM +0800, Bin Meng wrote:
> > > > On Wed, Dec 12, 2018 at 12:21 AM Andy Shevchenko
> > > > <andy.shevchenko@gmail.com> wrote:
>
> > > > > Since X86 implies SCSI and Intel Edison board does not use it, I have got a
> > > > > ===================== WARNING ======================
> > > > > This board does not use CONFIG_DM_SCSI. Please update
> > > > > the storage controller to use CONFIG_DM_SCSI before the v2019.07 release.
> > > > > Failure to update by the deadline may result in board removal.
> > > > > See doc/driver-model/MIGRATION.txt for more info.
> > > > > ====================================================
> > > > >
> > > > > Is anybody aware of?
> > > >
> > > > AFAIK , this warning message is intentional to push board maintainers
> > > > to convert their boards over to driver model.
> > > >
> > > > For the edison board, if SCSI is not used. you can turn it off in the
> > > > board defconfig file.
> > >
> > > Right.  Our warnings now are perhaps a bit too easy to trip over because
> > > there are cases like this where you don't need SCSI (or other things)
> > > but have them on without having DM_xxx and BLK enabled.  In this case
> > > the right thing to do is disable stuff you don't need.
> >
> > What stuff?
> > The platform does have DM_MMC and BLK as far as I can see, other than
> > that I have no idea how CONFIG_DM_SCSI becomes set.
> > Something broken upper, not on this certain board.
>
> config X86
> ...
>     imply DM_SCSI
> ...
>
> This has to be fixed, not my board. Message now is bogus.
>

No. SCSI is common for almost all x86 boards, hence we use 'imply'.
And we acknowledge that some boards may not have it so we don't use
'select'.  You can turn it off in your board defconfig.

Regards,
Bin

[U-Boot] Bogus message about SCSI during build

[Andy Shevchenko]

On Tue, Jan 8, 2019 at 3:04 AM Bin Meng <bmeng.cn@gmail.com> wrote:
> On Tue, Jan 8, 2019 at 2:38 AM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Mon, Jan 7, 2019 at 8:34 PM Andy Shevchenko
> > <andy.shevchenko@gmail.com> wrote:

> > > The platform does have DM_MMC and BLK as far as I can see, other than
> > > that I have no idea how CONFIG_DM_SCSI becomes set.
> > > Something broken upper, not on this certain board.
> >
> > config X86
> > ...
> >     imply DM_SCSI
> > ...
> >
> > This has to be fixed, not my board. Message now is bogus.
> >
>
> No. SCSI is common for almost all x86 boards, hence we use 'imply'.

Which is good and not a problem per se.

> And we acknowledge that some boards may not have it so we don't use
> 'select'.  You can turn it off in your board defconfig.

No, the board shouldn't care about some architecture defaults and
those defaults should be carefully chosen in the first place.
Nevertheless, I like the Tom's patch which fixes the actual problem.

-- 
With Best Regards,
Andy Shevchenko