From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 2/2] mmc: bring back partition init for non-DM MMC drivers
Date: Tue, 8 Jan 2019 22:44:52 -0500 [thread overview]
Message-ID: <20190109034452.GA8382@bill-the-cat> (raw)
In-Reply-To: <20181217100545.28369-3-andre.przywara@arm.com>
On Mon, Dec 17, 2018 at 10:05:45AM +0000, Andre Przywara wrote:
> Commit d0851c893706 ("blk: Call part_init() in the post_probe() method")
> removed the call to part_init() in mmc.c, as this is done by the DM_MMC
> framework.
> However Allwinner is (still) relying on a non-DM MMC driver, so we are
> now missing the implicit partition init, leading to failing MMC accesses
> due to the missing partition information.
>
> Bring the call back just for non-DM MMC driver to fix this regression.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Soeren Moch <smoch@web.de>
> ---
> drivers/mmc/mmc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index f5c821e308..d858127132 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2449,6 +2449,10 @@ static int mmc_startup(struct mmc *mmc)
> bdesc->revision[0] = 0;
> #endif
>
> +#if !defined(CONFIG_DM_MMC) && (!defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBDISK_SUPPORT))
> + part_init(bdesc);
> +#endif
> +
> return 0;
> }
So, this pushes pine_h64 over the limit:
https://travis-ci.org/trini/u-boot/jobs/477078336
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190108/cef95939/attachment.sig>
next prev parent reply other threads:[~2019-01-09 3:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 10:05 [U-Boot] [PATCH 0/2] mmc: Fix partition table init regression Andre Przywara
2018-12-17 10:05 ` [U-Boot] [PATCH 1/2] sunxi: drop default SPL_LIBDISK_SUPPORT enablement Andre Przywara
2019-01-05 1:56 ` Simon Glass
2019-01-10 2:30 ` [U-Boot] [U-Boot, " Tom Rini
2018-12-17 10:05 ` [U-Boot] [PATCH 2/2] mmc: bring back partition init for non-DM MMC drivers Andre Przywara
2019-01-05 1:56 ` Simon Glass
2019-01-05 17:31 ` Soeren Moch
2019-01-05 22:22 ` Petr Štetiar
2019-01-09 3:44 ` Tom Rini [this message]
2019-01-09 9:03 ` [U-Boot] [U-Boot, " André Przywara
2019-01-09 12:11 ` Tom Rini
2019-01-10 2:30 ` Tom Rini
2018-12-17 10:12 ` [U-Boot] [PATCH 0/2] mmc: Fix partition table init regression Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190109034452.GA8382@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox