[U-Boot] [U-Boot, 2/2] mmc: bring back partition init for non-DM MMC drivers

Tom Rini
2019-01-09T03:44:52Z

On Mon, Dec 17, 2018 at 10:05:45AM +0000, Andre Przywara wrote:

> Commit d0851c893706 ("blk: Call part_init() in the post_probe() method")
> removed the call to part_init() in mmc.c, as this is done by the DM_MMC
> framework.
> However Allwinner is (still) relying on a non-DM MMC driver, so we are
> now missing the implicit partition init, leading to failing MMC accesses
> due to the missing partition information.
>
> Bring the call back just for non-DM MMC driver to fix this regression.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Tested-by: Soeren Moch <smoch@web.de>
> ---
> drivers/mmc/mmc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
> index f5c821e308..d858127132 100644
> --- a/drivers/mmc/mmc.c
> +++ b/drivers/mmc/mmc.c
> @@ -2449,6 +2449,10 @@ static int mmc_startup(struct mmc *mmc)
> bdesc->revision[0] = 0;
> #endif
>
> +#if !defined(CONFIG_DM_MMC) && (!defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBDISK_SUPPORT))
> + part_init(bdesc);
> +#endif
> +
> return 0;
> }

So, this pushes pine_h64 over the limit:
https://travis-ci.org/trini/u-boot/jobs/477078336

--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190108/cef95939/attachment.sig>